I have attached at patch to pungi to allow for "relnotepkgs" and "relnotefilere" to be passed on the command line. This allows for packages other than fedora-release to contain the "relnotefilere" files . It also lets one define what files to include via the command line vs the hard coded defaults.
Thanks
-Connie Sieh
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On Mon, 17 Mar 2014 15:21:42 -0500 Connie Sieh csieh@fnal.gov wrote:
I have attached at patch to pungi to allow for "relnotepkgs" and "relnotefilere" to be passed on the command line. This allows for packages other than fedora-release to contain the "relnotefilere" files . It also lets one define what files to include via the command line vs the hard coded defaults.
Thanks
-Connie Sieh
Hi Connie,
can you please send patches from git. i find the --relnotefilere option to be confusing. how exactly would I use it as a user?
Dennis
From: Pat Riehecky riehecky@fnal.gov
This patch is for using pungi to compose non-fedora trees or to set custom release notes.
For example:
If CentOS were to use pungi for their media compose they would need these switches. And if a CentOS SIG were to respin the media with their own custom additions, they really should have their own release note rpm containing information on what they've customized.
Similarly, for Scientific Linux our 'Site/Spins' such as SL Fermi and SL CERN may wish to alter the way a release-note rpm is detected depending on how they chose to package it for their rebranded OS releases.
This is a fairly specific use case, but it really seems like the best way to solve this issue for us.
Pat Riehecky (1): Added option for setting release note files
src/bin/pungi.py | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-)
From: Pat Riehecky riehecky@fnal.gov
--- src/bin/pungi.py | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/src/bin/pungi.py b/src/bin/pungi.py index fc72b69..24f2f08 100755 --- a/src/bin/pungi.py +++ b/src/bin/pungi.py @@ -255,6 +255,12 @@ if __name__ == '__main__': help="Flag to enable processing the BuildInstall stage") parser.add_option("-I", action="store_true", default=False, dest="do_createiso", help="Flag to enable processing the CreateISO stage") + parser.add_option("--relnotepkgs", dest="relnotepkgs", type="string", + action="callback", callback=set_config, callback_args=(config, ), + help='Rpms which contain the release notes') + parser.add_option("--relnotefilere", dest="relnotefilere", type="string", + action="callback", callback=set_config, callback_args=(config, ), + help='Which files are the release notes -- GPL EULA')
(opts, args) = parser.parse_args()
The attached patch has been working well in the development of Scientific Linux 7. Since the attached patch allows for overriding a hard coded value, I'm hopeful that it will be considered for upstream inclusion.
Pat
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On Thu, 31 Jul 2014 08:44:01 -0500 Pat Riehecky riehecky@fnal.gov wrote:
The attached patch has been working well in the development of Scientific Linux 7. Since the attached patch allows for overriding a hard coded value, I'm hopeful that it will be considered for upstream inclusion.
Pat
Sorry for the delay, I have pushed the patch upstream.
Thanks
Dennis
buildsys@lists.fedoraproject.org
-
Connie Sieh -
Dennis Gilmore -
Pat Riehecky