On Tue, 2007-10-23 at 14:13 -0400, rob myers wrote:
attached is a patch that attempts to generalize checking out the
components used to build an SRPM. this patch supports CVS, GIT, and
SVN, but only CVS and SVN have been tested. the idea is to provide the
infrastructure for different SCM systems to be configured at run-time so
that users can choose their favorite system.
is there a better approach? did i miss something obvious? general
comments?
It looks pretty good, but I wonder if you need to make scmtype a config
option? I'd rather have Koji support all scmtypes all the time and have
some other method for restricting what URLs are valid locations to
download the source from. Maybe a list of valid hostnames or
hostname/path pairs?