bodhi/controllers.py | 2 --
1 file changed, 2 deletions(-)
New commits:
commit 857978ae8f8f7f644cca578afed29c8b1d5a0fd8
Merge: 111b7ac... 5ae630f...
Author: Luke Macken <lmacken(a)redhat.com>
Date: Tue Mar 23 00:48:14 2010 -0400
Merge branch 'master' of
git+ssh://git.fedoraproject.org/git/bodhi
commit 111b7ac0f8f534a0eaf7683b1b58a9dd7fbe03ab
Author: Luke Macken <lmacken(a)redhat.com>
Date: Tue Mar 23 00:45:56 2010 -0400
Don't set the package.suggest_requires permanently when the developer enables it.
By doing this, we have accumulated a large list unnecessary of packages that
now suggest that the user reboot their machine. If a package has ever been a
part of a large multi-build update where the developer has enabled the 'Suggest
Reboot' option, this package would always have this option. This is not ideal.
By disabling this, the 'suggest reboot' metadata option will only be enabled
if
the update has a package on bodhi's hardcoded list, or if the developer enables
that option manually.
diff --git a/bodhi/controllers.py b/bodhi/controllers.py
index c7deb1e..8b3902e 100644
--- a/bodhi/controllers.py
+++ b/bodhi/controllers.py
@@ -747,8 +747,6 @@ class Root(controllers.RootController):
package = Package.byName(nvr[0])
except SQLObjectNotFound:
package = Package(name=nvr[0])
- if suggest_reboot:
- package.suggest_reboot = True
# Update our ACL cache for this pkg
package.committers = buildinfo[build]['people']