bodhi/overrides.py
by Luke Macken
bodhi/overrides.py | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
New commits:
commit c211d28386da6dea75405992256bf8645920af30
Author: Luke Macken <lmacken(a)redhat.com>
Date: Thu Jun 9 16:36:18 2011 -0400
Handle postgres integrity errors
diff --git a/bodhi/overrides.py b/bodhi/overrides.py
index 0a8c1ae..c5da652 100644
--- a/bodhi/overrides.py
+++ b/bodhi/overrides.py
@@ -19,7 +19,6 @@ from turbogears import (expose, paginate, validate, validators, redirect,
error_handler, flash, identity, config)
from turbogears.controllers import Controller
from kitchen.iterutils import iterate
-from bodhi.util import url
try:
from fedora.tg.tg1utils import request_format
@@ -28,9 +27,10 @@ except ImportError:
from bodhi.model import BuildRootOverride, Release
from bodhi.buildsys import get_session
-from bodhi.util import get_nvr, get_pkg_pushers
+from bodhi.util import get_nvr, get_pkg_pushers, url
from bodhi.widgets import BuildRootOverrideForm
-from bodhi.exceptions import DuplicateEntryError
+from bodhi.exceptions import DuplicateEntryError, PostgresIntegrityError
+
log = logging.getLogger(__name__)
@@ -183,7 +183,7 @@ class BuildRootOverrideController(Controller):
override = BuildRootOverride(build=build,
notes=notes, submitter=identity.current.user_name,
expiration=expiration, releaseID=release.id)
- except DuplicateEntryError:
+ except (DuplicateEntryError, PostgresIntegrityError):
flash('Error: buildroot override for %r already exists' % build)
if request_format() == 'json': return dict()
raise redirect('/override/new')
13 years
bodhi/overrides.py
by Luke Macken
bodhi/overrides.py | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
New commits:
commit fd9a5825a2d88dd50f7ab062460c783ce4c28494
Author: Luke Macken <lmacken(a)redhat.com>
Date: Thu Jun 9 15:41:03 2011 -0400
Handle invalid package names in our override form
diff --git a/bodhi/overrides.py b/bodhi/overrides.py
index 049b710..0a8c1ae 100644
--- a/bodhi/overrides.py
+++ b/bodhi/overrides.py
@@ -142,7 +142,12 @@ class BuildRootOverrideController(Controller):
n, v, r = get_nvr(build)
# Make sure the user has commit rights
- people, groups = get_pkg_pushers(n)
+ try:
+ people, groups = get_pkg_pushers(n)
+ except Exception, e:
+ flash(str(e))
+ if request_format() == 'json': return dict()
+ raise redirect('/override/new')
if identity.current.user_name not in people[0]:
flash("Error: You do not have commit privileges to %s" % n)
if request_format() == 'json': return dict()
13 years
2 commits - bodhi/overrides.py
by Luke Macken
bodhi/overrides.py | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
New commits:
commit 73ffaaa1d217fc86784b9d00c9e3b77978f8d51d
Author: Luke Macken <lmacken(a)redhat.com>
Date: Thu Jun 9 15:21:41 2011 -0400
Stringify our messages before flashing them
diff --git a/bodhi/overrides.py b/bodhi/overrides.py
index 50649cb..049b710 100644
--- a/bodhi/overrides.py
+++ b/bodhi/overrides.py
@@ -87,7 +87,7 @@ class BuildRootOverrideController(Controller):
@expose(template="bodhi.templates.form")
def new(self, tg_errors=None, *args, **kw):
if tg_errors:
- flash(tg_errors)
+ flash(str(tg_errors))
expiration = datetime.utcnow() + \
timedelta(days=config.get('buildroot_overrides.expire_after', 1))
return dict(form=override_form, values={'expiration': expiration},
commit 575b46e244b40e87b17406ee6249e767a9b005a4
Author: Luke Macken <lmacken(a)redhat.com>
Date: Thu Jun 9 15:21:24 2011 -0400
Use bodhi.util.url so we get CSRF support in our new overrides
controller
diff --git a/bodhi/overrides.py b/bodhi/overrides.py
index 0e85f8b..50649cb 100644
--- a/bodhi/overrides.py
+++ b/bodhi/overrides.py
@@ -16,9 +16,10 @@ import logging
from datetime import datetime, timedelta
from sqlobject import AND, SQLObjectNotFound
from turbogears import (expose, paginate, validate, validators, redirect,
- error_handler, url, flash, identity, config)
+ error_handler, flash, identity, config)
from turbogears.controllers import Controller
from kitchen.iterutils import iterate
+from bodhi.util import url
try:
from fedora.tg.tg1utils import request_format
13 years
Changes to 'refs/tags/0.8.0'
by Luke Macken
Tag '0.8.0' created by Luke Macken <lmacken(a)redhat.com> at 2011-06-09 18:20 +0000
0.8.0
Changes since 0.7.17:
Luke Macken (1):
0.8.0 release
---
bodhi.egg-info/PKG-INFO | 2 +-
bodhi.spec | 2 +-
bodhi/release.py | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
---
13 years
bodhi.egg-info/PKG-INFO bodhi_nose.py bodhi/release.py bodhi.spec
by Luke Macken
bodhi.egg-info/PKG-INFO | 2 +-
bodhi.spec | 2 +-
bodhi/release.py | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
New commits:
commit 9dca0331c108cdede836904209547d2a6aeb377e
Author: Luke Macken <lmacken(a)redhat.com>
Date: Thu Jun 9 14:19:59 2011 -0400
0.8.0 release
diff --git a/bodhi.egg-info/PKG-INFO b/bodhi.egg-info/PKG-INFO
index 97ae1c4..fe88104 100644
--- a/bodhi.egg-info/PKG-INFO
+++ b/bodhi.egg-info/PKG-INFO
@@ -1,6 +1,6 @@
Metadata-Version: 1.0
Name: bodhi
-Version: 0.7.17
+Version: 0.8.0
Summary: Bodhi is a modular web-system that facilitates the process of publishing updates for a Fedora-based software distribution
Home-page: https://fedorahosted.org/bodhi
Author: Luke Macken
diff --git a/bodhi.spec b/bodhi.spec
index 7c2257d..acf0c9c 100644
--- a/bodhi.spec
+++ b/bodhi.spec
@@ -2,7 +2,7 @@
%{!?pyver: %define pyver %(%{__python} -c "import sys ; print sys.version[:3]")}
Name: bodhi
-Version: 0.7.17
+Version: 0.8.0
Release: 1%{?dist}
Summary: A modular framework that facilitates publishing software updates
Group: Applications/Internet
diff --git a/bodhi/release.py b/bodhi/release.py
index 5e2a3e1..9f5f797 100644
--- a/bodhi/release.py
+++ b/bodhi/release.py
@@ -1,4 +1,4 @@
-VERSION = '0.7.17'
+VERSION = '0.8.0'
NAME = 'bodhi'
DESCRIPTION = 'Bodhi is a modular web-system that facilitates the process of publishing updates for a Fedora-based software distribution'
AUTHOR = 'Luke Macken'
diff --git a/bodhi_nose.py b/bodhi_nose.py
old mode 100644
new mode 100755
13 years
Changes to 'refs/tags/0.7.17'
by Luke Macken
Tag '0.7.17' created by Luke Macken <lmacken(a)redhat.com> at 2011-06-08 15:46 +0000
0.7.17
Changes since 0.7.15:
Christopher Aillon (1):
Remind the user to log in before submitting a comment
Corey Maynard (1):
This patch makes the check for the package tags optional, by either making the URL an empty string or None in app.cfg.
Luke Macken (50):
Fix a bug in our bugzilla commenting code
Hack around urlgrabber's inability to handle unicode strings
Document bodhi's new arch handling code
Make our test case query optional
Track proventester karma in our metrics.py
Be more robust in our pending tag removal
Perform client-side validation on the update type and request when doing `make update` (#597)
Set the PYTHONPATH in our Makefile init target
Apply a patch from Corey Maynard to make our Koji urls configurable.
Add the appropriate pending tag when adding a build to an existing update.
Fix a typo in the last patch
Initial buildroot override support
Remove an unnecessary comment block
Add the ability to exclude a user from receiving email (eg: autoqa)
More buildroot override improvements
More buildroot override changes
prep for 0.7.16
Some identity fixes for buildroot overrides
Set our mod_wsgi config to noreplace in our spec
Fix our "critpath pushed to stable w/o karma" metric
Minor tweak
A couple new metrics:
fix a bug in our metrics
Add an email boolean to our comment API so services like AutoQA can choose not
Stacked validators work again in TG.
Add an improved buildroot list controller
Set the expiration date on overrides, and don't delete them from the database
Improvements to our BuildrootOverride.save() method
Improve our overrides list
Add more buildroot override commands to the bodhi client
Allow empty buildroot override expiration dates
Require CherryPy<3.0
Automatically expire overrides when they hit stable, if they haven't already been
Add override editing functionality to the controller
Enhance our override list
Update the bodhi client to support override editing
More buildroot overrides tweaks
Update details are no longer optional.
Fix a spacing issue
Add a unit test to ensure that notes are now mandatory
Add a cutom test runner to avoid CherryPy conflicts
Update our 'make test' target
Fix a bug when adding a build for a different release to an update
Fix broken unit tests
More tweaking of our editing code
Disable a broken unit test that we can't hack around, for now.
Fix a busted test case
Optimize querying for updates by bug numbers (#610)
Don't hardcode F15 policy in our config, just leave it as an example.
0.7.16
---
Makefile | 4
bodhi.egg-info/PKG-INFO | 2
bodhi.egg-info/SOURCES.txt | 3
bodhi.egg-info/requires.txt | 3
bodhi.spec | 4
bodhi/config/app.cfg | 32 ++
bodhi/controllers.py | 133 +++++++---
bodhi/jobs.py | 25 +
bodhi/mail.py | 18 +
bodhi/masher.py | 9
bodhi/metadata.py | 57 ++--
bodhi/model.py | 64 ++++-
bodhi/overrides.py | 276 +++++++++++++++++++++
bodhi/release.py | 2
bodhi/static/css/layout.css | 418 +++++++++++++++------------------
bodhi/templates/captchacommentform.kid | 5
bodhi/templates/login.kid | 25 -
bodhi/templates/master.kid | 1
bodhi/templates/metrics.kid | 1
bodhi/templates/new.kid | 1
bodhi/templates/overrideform.kid | 43 +++
bodhi/templates/overrides.kid | 90 +++++++
bodhi/templates/pkg.kid | 7
bodhi/templates/show.kid | 6
bodhi/templates/welcome.kid | 6
bodhi/tests/test_controllers.py | 141 +++++++----
bodhi/tests/test_model.py | 15 -
bodhi/tools/client.py | 94 +++++++
bodhi/tools/metrics.py | 34 ++
bodhi/util.py | 1
bodhi/widgets.py | 18 +
bodhi_nose.py | 11
setup.py | 1
33 files changed, 1164 insertions(+), 386 deletions(-)
---
13 years
Changes to 'refs/tags/0.7.16'
by Luke Macken
Tag '0.7.16' created by Luke Macken <lmacken(a)redhat.com> at 2011-06-06 21:57 +0000
0.7.16
Changes since 0.7.15:
Christopher Aillon (1):
Remind the user to log in before submitting a comment
Corey Maynard (1):
This patch makes the check for the package tags optional, by either making the URL an empty string or None in app.cfg.
Luke Macken (50):
Fix a bug in our bugzilla commenting code
Hack around urlgrabber's inability to handle unicode strings
Document bodhi's new arch handling code
Make our test case query optional
Track proventester karma in our metrics.py
Be more robust in our pending tag removal
Perform client-side validation on the update type and request when doing `make update` (#597)
Set the PYTHONPATH in our Makefile init target
Apply a patch from Corey Maynard to make our Koji urls configurable.
Add the appropriate pending tag when adding a build to an existing update.
Fix a typo in the last patch
Initial buildroot override support
Remove an unnecessary comment block
Add the ability to exclude a user from receiving email (eg: autoqa)
More buildroot override improvements
More buildroot override changes
prep for 0.7.16
Some identity fixes for buildroot overrides
Set our mod_wsgi config to noreplace in our spec
Fix our "critpath pushed to stable w/o karma" metric
Minor tweak
A couple new metrics:
fix a bug in our metrics
Add an email boolean to our comment API so services like AutoQA can choose not
Stacked validators work again in TG.
Add an improved buildroot list controller
Set the expiration date on overrides, and don't delete them from the database
Improvements to our BuildrootOverride.save() method
Improve our overrides list
Add more buildroot override commands to the bodhi client
Allow empty buildroot override expiration dates
Require CherryPy<3.0
Automatically expire overrides when they hit stable, if they haven't already been
Add override editing functionality to the controller
Enhance our override list
Update the bodhi client to support override editing
More buildroot overrides tweaks
Update details are no longer optional.
Fix a spacing issue
Add a unit test to ensure that notes are now mandatory
Add a cutom test runner to avoid CherryPy conflicts
Update our 'make test' target
Fix a bug when adding a build for a different release to an update
Fix broken unit tests
More tweaking of our editing code
Disable a broken unit test that we can't hack around, for now.
Fix a busted test case
Optimize querying for updates by bug numbers (#610)
Don't hardcode F15 policy in our config, just leave it as an example.
0.7.16
---
Makefile | 4
bodhi.egg-info/PKG-INFO | 2
bodhi.egg-info/SOURCES.txt | 3
bodhi.egg-info/requires.txt | 3
bodhi.spec | 4
bodhi/config/app.cfg | 32 ++
bodhi/controllers.py | 133 +++++++---
bodhi/jobs.py | 25 +
bodhi/mail.py | 18 +
bodhi/masher.py | 9
bodhi/metadata.py | 57 ++--
bodhi/model.py | 64 ++++-
bodhi/overrides.py | 276 +++++++++++++++++++++
bodhi/release.py | 2
bodhi/static/css/layout.css | 418 +++++++++++++++------------------
bodhi/templates/captchacommentform.kid | 5
bodhi/templates/login.kid | 25 -
bodhi/templates/master.kid | 1
bodhi/templates/metrics.kid | 1
bodhi/templates/new.kid | 1
bodhi/templates/overrideform.kid | 43 +++
bodhi/templates/overrides.kid | 90 +++++++
bodhi/templates/pkg.kid | 7
bodhi/templates/show.kid | 6
bodhi/templates/welcome.kid | 6
bodhi/tests/test_controllers.py | 141 +++++++----
bodhi/tests/test_model.py | 15 -
bodhi/tools/client.py | 94 +++++++
bodhi/tools/metrics.py | 34 ++
bodhi/util.py | 1
bodhi/widgets.py | 18 +
bodhi_nose.py | 11
setup.py | 1
33 files changed, 1164 insertions(+), 386 deletions(-)
---
13 years
2 commits - bodhi/config bodhi.egg-info/PKG-INFO bodhi/release.py bodhi.spec
by Luke Macken
bodhi.egg-info/PKG-INFO | 2 +-
bodhi.spec | 2 +-
bodhi/config/app.cfg | 8 ++++----
bodhi/release.py | 2 +-
4 files changed, 7 insertions(+), 7 deletions(-)
New commits:
commit a0f3739aed121a721e6b0514d0f3edc1782c0a22
Author: Luke Macken <lmacken(a)redhat.com>
Date: Mon Jun 6 17:57:48 2011 -0400
0.7.16
diff --git a/bodhi.egg-info/PKG-INFO b/bodhi.egg-info/PKG-INFO
index a057c64..97ae1c4 100644
--- a/bodhi.egg-info/PKG-INFO
+++ b/bodhi.egg-info/PKG-INFO
@@ -1,6 +1,6 @@
Metadata-Version: 1.0
Name: bodhi
-Version: 0.7.16
+Version: 0.7.17
Summary: Bodhi is a modular web-system that facilitates the process of publishing updates for a Fedora-based software distribution
Home-page: https://fedorahosted.org/bodhi
Author: Luke Macken
diff --git a/bodhi.spec b/bodhi.spec
index 6c66491..7c2257d 100644
--- a/bodhi.spec
+++ b/bodhi.spec
@@ -2,7 +2,7 @@
%{!?pyver: %define pyver %(%{__python} -c "import sys ; print sys.version[:3]")}
Name: bodhi
-Version: 0.7.16
+Version: 0.7.17
Release: 1%{?dist}
Summary: A modular framework that facilitates publishing software updates
Group: Applications/Internet
diff --git a/bodhi/release.py b/bodhi/release.py
index a70b9ef..5e2a3e1 100644
--- a/bodhi/release.py
+++ b/bodhi/release.py
@@ -1,4 +1,4 @@
-VERSION = '0.7.16'
+VERSION = '0.7.17'
NAME = 'bodhi'
DESCRIPTION = 'Bodhi is a modular web-system that facilitates the process of publishing updates for a Fedora-based software distribution'
AUTHOR = 'Luke Macken'
commit fdce01b0b0c5f1e9e145dd88b3d4bdf79ced7b7d
Author: Luke Macken <lmacken(a)redhat.com>
Date: Mon Jun 6 17:56:29 2011 -0400
Don't hardcode F15 policy in our config, just leave it as an example.
diff --git a/bodhi/config/app.cfg b/bodhi/config/app.cfg
index a500b02..690fb7b 100644
--- a/bodhi/config/app.cfg
+++ b/bodhi/config/app.cfg
@@ -204,10 +204,10 @@ fedora_epel.mandatory_days_in_testing = 14
# Release status
# pre-beta enforces the Pre Beta policy defined here:
# https://fedoraproject.org/wiki/Updates_Policy
-f15.status = 'pre_beta'
-f15.pre_beta.mandatory_days_in_testing = 3
-f15.pre_beta.critpath.num_admin_approvals = 1
-f15.pre_beta.critpath.min_karma = 1
+#f15.status = 'pre_beta'
+#f15.pre_beta.mandatory_days_in_testing = 3
+#f15.pre_beta.critpath.num_admin_approvals = 1
+#f15.pre_beta.critpath.min_karma = 1
testing_approval_msg = "This update has reached %d days in testing and can be pushed to stable now if the maintainer wishes"
13 years