On Thu, 2013-11-21 at 17:57 +0100, Hubert Kario wrote:
Hi all,
More or less final version, full functionality together with
test suite.
I haven't tested on RHEL 3 as the test harness doesn't work:
./test.sh: line 82: conditional binary operator expected
./test.sh: line 82: syntax error near `=~'
./test.sh: line 82: ` if [[ "$status" =~ ^$expected$ ]]; then'
RHEL 4 and RHEL5 (!) isn't much better:
File "/root/beakerlib/src/test/../python/journalling.py", line 351
with open("/etc/redhat-release", "r") as release_file:
^
SyntaxError: invalid syntax
rlJournalStart: Failed to initialize the journal. Bailing out...
I verified the library using the automated test suite on Fedora 19,
RHEL 6 and RHEL 7. I also manually checked if it works correctly
on RHEL 5 by copying it to /plugins and running few simple tests
the usual way. And, as I've mentioned in comments and previously,
it /should/ work on RHEL3 and later, trivial errors not
withstanding.
Yeah, I carry compatibility patches in RPMs for old RHELs for some
cases, allowing us to have at least a bit modern code (like the 'with X
do Y' python syntax) in upstream. Thanks for thorough testing.
PM