Overall results:
964 tests, 5 failures, 0 errors, 3 skips in 3032.7s
Key packages and versions:
python-sqlalchemy-0.8.2-1.fc20.x86_64, python-requests-1.1.0-4.fc20.noarch,
python-formencode-1.2.6-2.fc20.noarch
I deliberately used python-requests-1.1.0-4.fc20.noarch, instead of
python-requests-1.2.3-5.fc20 (latest on Fedora 20).
Failures:
These all result in assertion failures with the new version for python-formencode:
bkr.inttest.client.test_group_create:GroupCreateTest.test_group_create
bkr.inttest.client.test_group_modify:GroupModifyTest.test_group_modify_display_name
bkr.inttest.client.test_group_modify:GroupModifyTest.test_group_modify_group_name
bkr.inttest.server.selenium.test_group_edit:TestGroupsWD.test_check_group_name_display_name_length
The problem is the error message has been "fixed" in the new version, but it
remains the same
on the older versions. Here is an example:
- Enter a value less than 255 characters long?
+ Enter a value not more than 255 characters long?
So shall we instead have an "or" condition here in the assertion so that it
tests
against both possible error messages?
"Known" Fedora failure:
bkr.inttest.server.test_jobs:TestJobsController.test_job_xml_can_be_roundtripped
With python-requests-1.2.3-5.fc20, this patch is needed:
diff --git a/Client/src/bkr/client/__init__.py b/Client/src/bkr/client/__init__.py
index eb4a4fd..2414bf7 100644
--- a/Client/src/bkr/client/__init__.py
+++ b/Client/src/bkr/client/__init__.py
@@ -63,7 +63,7 @@ def request(self, method, url, **kwargs):
# turn 'json' parameter into a suitably formatted request
if 'json' in kwargs:
kwargs['data'] = json.dumps(kwargs.pop('json'))
- kwargs.setdefault('headers',
[]).append(('Content-Type', 'application/json'))
+ kwargs.setdefault('headers',
{}).update({'Content-Type': 'application/json'})
return super(BeakerClientRequestsSession, self).request(method, url,
**kwargs)
return BeakerClientRequestsSession()
Fortunately, this is compatible with 1.1, so we should get this patch merged.
Thoughts on the above suggested changes?
Best,
Amit.
--
Amit Saha <
http://echorand.me>
Infrastructure Engineering and Development
Red Hat, Inc.