On 01/08/2010 07:58 AM, Raymond Mancy wrote:
Something wrong with the net connection I'm using. Can't connect to the repo.
Here is the patch file for my latest changes as per your spec below.
I've made it so whenever the user tries to return no columns, they are returned the
I can't think of a single use case where they would want to return no data from the
I just finished testing your latest code for ticket51. Seems to work
well after a couple minor adjustments..
1 - class Utility was defined twice, Second one overrode the previous
one so methods were missing. I remove the extra class and moved the one
method in it to the other. Not sure what happened here? Bad merge?
2 - I made the following change..
@@ -519,9 +518,7 @@ class Root(RPCRoot):
- systems = sys_search.return_results()
- new_systems = System.all(identity.current.user,system = systems)
- return new_systems
+ return sys_search.return_results()
I don't understand why the call to System.all(), we already start out
with a System query object which started from one of the following:
I did a couple different searches and everything acts as expected.
Started from Available link or Free, also tried Machine and Laptop. All
works as expected.
I think we will have requests for more columns to be added in the
future.. We will probably want to move the checkbox list into a table
so it takes up less room. Maybe 3 columns across? But that can be in
an update. :-)
I won't merge into master until I hear back. :-)
----- "Bill Peck"<bpeck(a)redhat.com> wrote:
> From: "Bill Peck"<bpeck(a)redhat.com>
> To: "Raymond Mancy"<rmancy(a)redhat.com>
> Cc: "beaker-devel"<beaker-devel(a)lists.fedorahosted.org>
> Sent: Friday, January 8, 2010 4:46:57 AM GMT +10:00 Brisbane
> Subject: Re: Alternative to disable custom columns.
> On 01/07/2010 12:48 AM, Raymond Mancy wrote:
>> Hi Bill, Just wanting your thoughts on a good alternative to the
> disable result column checkbox on ticket51.
>> The only reasonable alternative I can come up with is the
>> Initially, in the checkbox list of result columns, have our default
> columns selected (System,Status,Vendor...etc).
>> Have another link up the top that allows them to populate that
> checkbox list with only default values (so they
>> can easily go from a heavily customised result set back to the
>> I'm trying to make it easy for the user to go between a customised
> search result and a default search result. If
>> they wanted to go between the two quite often it could get fiddley
> if they had to do it all manually. Maybe I'm
>> overstating this feature though.
> Hi Raymond,
> Here are my thoughts on testing ticket51 so far.
> - Default to having all current columns selected. (The ones we
> - Have three "shortcut" links, Select All, Select None, and Select
> - move these to under the checkbox div. I don't think we want to
> see them unless we are actually clicking and unclicking checkboxes.
> Users will be confused otherwise.
> - Remove the "Disable Custom Result Columns" checkbox
> Assuming we can get the above correct then we could just have one code
> path for the grid.
> It would also allow a user to set their preferred columns in prefs.
> btw - while testing I received a 500 ISE when selecting
> System/PowerType. I think this blows up because of the nested
> Power->Type relation. Might need to move PowerType to a Power search
> object which has Type in it. thoughts?