On Fri, Mar 8, 2013 at 3:16 PM, Don Zickus <dzickus(a)redhat.com> wrote:
Hi Folks,
Recently a bunch of autotest and beaker folks have been discussing how to get
an autotest client working under beaker (namely Nick, Dan, Bill from beaker and
Lucas, Cleber, Ademar from autotest).
A long time ago Jan Stancek whipped up some code to do that based on some
discussions we both had. I later modified a bunch of his code and came up with
these patches.
I lasted touched these patches back in August 2012. I never finished polishing
them off or completed my testing due to other Red Hat obligations.
I am presenting these patches as a starting point for discussions as to how Jan
and myself solved various problems. They are very much 'beta' patches (there
has been a lot of testing so they were stable at one point).
Unfortunately, I don't remember how all the pieces worked so instead of
breaking the files into digestable chunks, I am just submitting whole files as
new (well the first patch is a 'patch').
I rebased them on to the latest autotest/HEAD as of today. Though I didn't
test them.
Please be kind. I am cross-posting to various mailing lists to let anyone
interested participate.
The end goal is to have autotest client work with the beaker server smoothly.
This would allow various autotest projects to leverage the
provisioning/inventorying mechanisms provided by beaker for various labs.
These patches look like a great start. There are some coding style
inadequacies, that will need to be addressed, mainly:
1) Fix usage of CamelCase. The only exception are class names.
2) Docstring format
3) Use of old style classes
There are other small issues, mostly related to PEP8 here and there.
That all said, I'm going patch by patch checking the general goals,
and running some static checking to shake up small bugs.
--
Lucas