OK, gang, here it comes:
I created new git branch 'new_koji_watcher':
http://git.fedorahosted.org/git/?p=autoqa.git;a=shortlog;h=refs/heads/new_koji_watcher
The information from first email https://fedorahosted.org/pipermail/autoqa-devel/2010-December/001441.html still applies, although the batch part should be fixed (i.e. runs on my testing machine)/
Feel free to comment/throw stones :)
Joza
----- Original Message ----- From: "Kamil Paral" kparal@redhat.com To: "AutoQA development" autoqa-devel@lists.fedorahosted.org Sent: Monday, December 13, 2010 2:31:24 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna Subject: Re: PATCH proposal - new Koji watcher
----- "Josef Skladanka" jskladan@redhat.com wrote:
Thanks Kamil, that will teach me to post patches on late fridays :)
/me hates typos & is fixing the patch right now
Do you think it would be better to push the changes into new git branch,
Yes, yes, yes! :) I encourage everyone with medium or large-size patch to also push it to some branch if possible. It's just much easier to switch to that code, there are no "cannot apply patch" problems and one can fix typos right away, if desired.
OTOH this might be overkill for smaller patches.
or should I send yet another huuuuge patch?
Of course in-line patches are still a good idea, even if you have published it in a branch, since it's easy to comment on specific parts of code this way.
J.
_______________________________________________ autoqa-devel mailing list autoqa-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/autoqa-devel
autoqa-devel@lists.fedorahosted.org