Hi Will,
I've been playing around with the bodhi watcher and -pending tags, and I've found out, that bodhi watcher lists builds, which already are in the repos, and not those with -pending tags.
This assumption is also backed up by the fact, that bodhi watcher lists the 'update-id' value. Not sure what that means, but once again, packages with -pending tag do not have this update-id value in Bodhi.
The bodhi wathcer actually does not list those -pending builds at all. So even though I believe, that listing builds recently tagged with -pending is the right way, since the purpose of post-bodhi event should be to test packages before they are pushed to repos, so we can potentially stop the push, I'd rather have it confirmed to prevent possible mishaps caused by my misunderstanding of the topic.
Thanks
Joza
----- Original Message -----
Hi Will,
I've been playing around with the bodhi watcher and -pending tags, and I've found out, that bodhi watcher lists builds, which already are in the repos, and not those with -pending tags.
This assumption is also backed up by the fact, that bodhi watcher lists the 'update-id' value. Not sure what that means, but once again, packages with -pending tag do not have this update-id value in Bodhi.
The bodhi wathcer actually does not list those -pending builds at all. So even though I believe, that listing builds recently tagged with -pending is the right way, since the purpose of post-bodhi event should be to test packages before they are pushed to repos, so we can potentially stop the push, I'd rather have it confirmed to prevent possible mishaps caused by my misunderstanding of the topic.
Thanks
Joza
I have compared of the new koji watcher and the bodhi watcher. My findings:
1. bodhi watcher does not intercept -updates-testing requests at all, just -updates requests. New koji watcher does both. (good) 2. for f14-updates-pending tag, the output of bodhi watcher matches the output of the new koji watcher (good) 3. bodhi watcher lists massive list of updates that our new koji watcher does not detect. How's that possible? I have digged into that issue and found out:
These two updates were submitted manually to -updates and our new koji watcher detected them: https://admin.fedoraproject.org/updates/xguest-1.0.9-2.fc14 https://admin.fedoraproject.org/updates/Cython-0.14-2.fc14
But these two updates were auto-karma-submitted to -updates and our new koji watcher didn't detect them: https://admin.fedoraproject.org/updates/gdbm-1.8.3-8.fc14 https://admin.fedoraproject.org/updates/PackageKit-0.6.11-2.fc14 Please also note that they don't have -updates-pending tag (the former two have it): $ koji list-tag-history --build BUILD
So, maybe this is a bug in Bodhi? I'll try to contact lmacken.
----- Original Message -----
I have compared of the new koji watcher and the bodhi watcher. My findings:
- bodhi watcher does not intercept -updates-testing requests at all,
just -updates requests. New koji watcher does both. (good) 2. for f14-updates-pending tag, the output of bodhi watcher matches the output of the new koji watcher (good) 3. bodhi watcher lists massive list of updates that our new koji watcher does not detect. How's that possible? I have digged into that issue and found out:
These two updates were submitted manually to -updates and our new koji watcher detected them: https://admin.fedoraproject.org/updates/xguest-1.0.9-2.fc14 https://admin.fedoraproject.org/updates/Cython-0.14-2.fc14
But these two updates were auto-karma-submitted to -updates and our new koji watcher didn't detect them: https://admin.fedoraproject.org/updates/gdbm-1.8.3-8.fc14 https://admin.fedoraproject.org/updates/PackageKit-0.6.11-2.fc14 Please also note that they don't have -updates-pending tag (the former two have it): $ koji list-tag-history --build BUILD
So, maybe this is a bug in Bodhi? I'll try to contact lmacken.
Yes, there were some bugs in Bodhi. Let's hope these bugs were the source of all the issues.
----- Forwarded Message ----- From: "Luke Macken" lmacken@redhat.com To: "Kamil Paral" kparal@redhat.com Cc: "Josef Skladanka" jskladan@redhat.com Sent: Monday, January 17, 2011 6:47:00 PM Subject: Re: bodhi bug - missing updates-pending tag?
Hey Kamil,
Yes, this is a bodhi bug.
There were a few places that didn't properly add/remove the pending tag, so I hopefully fixed them in: https://fedorahosted.org/bodhi/changeset/d6218003bda6ce41f85d1a71260aa4152ec...
I'll try and get this code into production ASAP.
Cheers,
luke
autoqa-devel@lists.fedorahosted.org