Thanks Kamil, that will teach me to post patches on late fridays :)
/me hates typos & is fixing the patch right now
Do you think it would be better to push the changes into new git branch, or should I send yet another huuuuge patch?
J.
----- Original Message ----- From: "Kamil Paral" kparal@redhat.com To: "AutoQA development" autoqa-devel@lists.fedorahosted.org Sent: Monday, December 13, 2010 1:15:00 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna Subject: Re: PATCH proposal - new Koji watcher
----- "Kamil Paral" kparal@redhat.com wrote:
It's too much new code to check for correctness, but I tried to run that, and I have a few tracebacks for you :)
Ok, some more: http://fpaste.org/sVA9/
Those 'atest job create' failures are expected (no autotest server package installed), the rest are not.
Maybe we should print out the command being run with verbose turned on even if dryrun is turned off, what say you?
_______________________________________________ autoqa-devel mailing list autoqa-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/autoqa-devel
----- "Josef Skladanka" jskladan@redhat.com wrote:
Thanks Kamil, that will teach me to post patches on late fridays :)
/me hates typos & is fixing the patch right now
Do you think it would be better to push the changes into new git branch,
Yes, yes, yes! :) I encourage everyone with medium or large-size patch to also push it to some branch if possible. It's just much easier to switch to that code, there are no "cannot apply patch" problems and one can fix typos right away, if desired.
OTOH this might be overkill for smaller patches.
or should I send yet another huuuuge patch?
Of course in-line patches are still a good idea, even if you have published it in a branch, since it's easy to comment on specific parts of code this way.
J.
autoqa-devel@lists.fedorahosted.org