Hey gang,
While testing packaging and deployment, I just noticed that the autoqa.conf in master doesn't have a value for the field 'bodhi_server'.
# URL of Bodhi instance used for communication about package updates # (leave blank for default) bodhi_server =
Should that be empty, or should a default value of https://admin.fedoraproject.org/updates be there? I just wanted to confirm my understanding.
Thanks, James
----- Original Message -----
Hey gang,
While testing packaging and deployment, I just noticed that the autoqa.conf in master doesn't have a value for the field 'bodhi_server'.
# URL of Bodhi instance used for communication about package updates # (leave blank for default) bodhi_server =
Should that be empty, or should a default value of https://admin.fedoraproject.org/updates be there? I just wanted to confirm my understanding.
This is from bodhi_utils.py:
server = autoqa_conf.get('resources', 'bodhi_server') ops = {'base_url': server} if server else {} bodhi = fedora.client.bodhi.BodhiClient(username=user, password=pswd, **ops)
If 'server' is empty, the default one from BodhiClient class is used (yes, that's https://admin.fedoraproject.org/updates). We could have it explicitly defined in autoqa.conf and thus always passed into BodhiClient through **ops, but mkrizek and I decided it's better just to leave it empty, if we really want to use the default one (although improbable, it can change in the future, etc).
That's why the "# (leave blank for default)" comment is included in the conf file. Do you think we should improve the comment somehow? Or use different approach?
Thanks, Kamil
On Fri, 2011-01-21 at 04:03 -0500, Kamil Paral wrote:
----- Original Message -----
Hey gang,
While testing packaging and deployment, I just noticed that the autoqa.conf in master doesn't have a value for the field 'bodhi_server'.
# URL of Bodhi instance used for communication about package updates # (leave blank for default) bodhi_server =
Should that be empty, or should a default value of https://admin.fedoraproject.org/updates be there? I just wanted to confirm my understanding.
This is from bodhi_utils.py:
server = autoqa_conf.get('resources', 'bodhi_server') ops = {'base_url': server} if server else {} bodhi = fedora.client.bodhi.BodhiClient(username=user, password=pswd, **ops)
If 'server' is empty, the default one from BodhiClient class is used (yes, that's https://admin.fedoraproject.org/updates). We could have it explicitly defined in autoqa.conf and thus always passed into BodhiClient through **ops, but mkrizek and I decided it's better just to leave it empty, if we really want to use the default one (although improbable, it can change in the future, etc).
Clearly not a big issue. Just something that struck me as different when I was doing a fresh install for an autotest deployment yesterday. Other similar cfg options (koji_url etc...) had default values specified in autoqa.conf.
That's why the "# (leave blank for default)" comment is included in the conf file. Do you think we should improve the comment somehow? Or use different approach?
Ah I see now! I was having a hard time figuring out where in the code we initialize the value to the proper URL. But I see now that the default value for bodhi_server is really handled by the constructor for fedora.client.bodhi.BodhiClient. I understand why we default to empty, and accept the defaults provided by BodhiClient.
Nothing to see here :)
Thanks, James
autoqa-devel@lists.fedorahosted.org