On Thu, 2010-01-14 at 15:39 -0500, Will Woods wrote:
On Thu, 2010-01-14 at 15:29 -0500, James Laska wrote:
On Thu, 2010-01-14 at 13:29 -0500, Will Woods wrote:
On Thu, 2010-01-14 at 12:59 -0500, James Laska wrote:
Not sure what's going on, but trying to investigate why this test was comparing two packages of the same nvr.
> import autoqa.koji_utils > koji = autoqa.koji_utils.SimpleKojiClientSession() > for pb in koji.list_previous_releases("PackageKit", "dist-f12-updates-candidate").values():
... print "Previous package for %s was %s" % ( pb['tag_name'], pb['nvr'] ) ... Previous package for dist-f12-updates was PackageKit-0.5.6-1.fc12 Previous package for dist-f12-updates was PackageKit-0.5.6-1.fc12 Previous package for dist-f12 was PackageKit-0.5.4-0.1.20091029git.fc12
I'm not sure whether list_previous_releases() is in error for returning a duplicate entry or whether the rpmguard control file should handle duplicate entries and keep scanning for the previous package?
I'd think the rpmguard control file should skip testing if the new package is the same as the previous release. But I wonder what would cause this to happen? Also, why is dist-f12-updates listed twice?
I've updated my script to produce more appropriate output.
$ python /tmp/koji_list_previous_releases.py PackageKit dist-f12-updates-candidate latest_by_tag(dist-f12-updates, PackageKit) - PackageKit-0.5.6-1.fc12 latest_by_tag(dist-f12-updates-testing, PackageKit) - PackageKit-0.5.6-1.fc12 latest_by_tag(dist-f12, PackageKit) - PackageKit-0.5.4-0.1.20091029git.fc12
I'm not a master of the inheritance chain of koji tags, but I think in this case, it should have compared PackageKit-0.5.6-1.fc12 to PackageKit-0.5.4-0.1.20091029git.fc12.
No, because apparently PackageKit-0.5.6-1.fc12 is already public in f12-updates. The test is supposed to check things that land in dist-f12-updates-candidate (e.g. new builds) against whatever is currently public.
Thanks Will, helpful explanation. This highlights that my use-case is a bit outside the scope of the test (see below).
So somehow PackageKit-0.5.6-1.fc12 appeared in updates-candidate despite it already being in the updates repo? I wonder how that happened.
This was manually submitted for comparison as I was interested to see how rpmguard would flag a specific set of changes. For doing a manual comparison, I should have just downloaded the packages locally, and ran rpmguard by hand.
Anyway, if the "new" build is not newer than the current public build, the new build won't be considered an update, and there's nothing to compare, so we should skip the test altogether.
Thanks, James