On Thu, 2010-01-14 at 13:29 -0500, Will Woods wrote:
On Thu, 2010-01-14 at 12:59 -0500, James Laska wrote:
Not sure what's going on, but trying to investigate why this test was comparing two packages of the same nvr.
import autoqa.koji_utils koji = autoqa.koji_utils.SimpleKojiClientSession() for pb in koji.list_previous_releases("PackageKit", "dist-f12-updates-candidate").values():
... print "Previous package for %s was %s" % ( pb['tag_name'], pb['nvr'] ) ... Previous package for dist-f12-updates was PackageKit-0.5.6-1.fc12 Previous package for dist-f12-updates was PackageKit-0.5.6-1.fc12 Previous package for dist-f12 was PackageKit-0.5.4-0.1.20091029git.fc12
I'm not sure whether list_previous_releases() is in error for returning a duplicate entry or whether the rpmguard control file should handle duplicate entries and keep scanning for the previous package?
I'd think the rpmguard control file should skip testing if the new package is the same as the previous release. But I wonder what would cause this to happen? Also, why is dist-f12-updates listed twice?
I've updated my script to produce more appropriate output.
$ python /tmp/koji_list_previous_releases.py PackageKit dist-f12-updates-candidate latest_by_tag(dist-f12-updates, PackageKit) - PackageKit-0.5.6-1.fc12 latest_by_tag(dist-f12-updates-testing, PackageKit) - PackageKit-0.5.6-1.fc12 latest_by_tag(dist-f12, PackageKit) - PackageKit-0.5.4-0.1.20091029git.fc12
I'm not a master of the inheritance chain of koji tags, but I think in this case, it should have compared PackageKit-0.5.6-1.fc12 to PackageKit-0.5.4-0.1.20091029git.fc12.
I believe that information is provided, but we may not be filtering properly in the rpmguard control file. Kamil, what do you think?
Thanks, James