#408: depcheck: Argument list too long ---------------------+------------------------------- Reporter: kparal | Owner: Type: defect | Status: new Priority: minor | Milestone: Nice to have soon Component: tests | Keywords: Blocked By: | Blocking: ---------------------+------------------------------- {{{ Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/autoqa/decorators.py", line 72, in newf f_result = f(*args, **kwargs) #call the decorated function File "/usr/share/autotest/tests/depcheck/depcheck.py", line 174, in run_once depcheck_output = utils.system_output(cmd, retain_output=True) File "/usr/share/autotest/common_lib/base_utils.py", line 931, in system_output args=args).stdout File "/usr/share/autotest/common_lib/base_utils.py", line 654, in run stderr_level=get_stderr_level(stderr_is_expected)),), File "/usr/share/autotest/common_lib/base_utils.py", line 79, in __init__ stdin=stdin) File "/usr/lib64/python2.7/subprocess.py", line 672, in __init__ errread, errwrite) File "/usr/lib64/python2.7/subprocess.py", line 1202, in _execute_child raise child_exception OSError: [Errno 7] Argument list too long }}}
http://autoqa- stg.fedoraproject.org/results/27644-autotest/virt24.qa/depcheck/results/full.log
Sometimes we hit system limits.
Proposed solution: Write pending builds to one file, accepted builds to a different file, then provide these files using different command line options to depcheck. Place both files in the results directory.
I don't think this issue is really hot, because it happens seldom. Putting to "nice to have soon".
#408: depcheck: Argument list too long --------------------+-------------------------------- Reporter: kparal | Owner: jskladan Type: defect | Status: assigned Priority: minor | Milestone: Nice to have soon Component: tests | Resolution: Keywords: | Blocked By: Blocking: | --------------------+-------------------------------- Changes (by jskladan):
* owner: => jskladan * status: new => assigned
Comment:
Patch in reviewboard. Note that the patch is based on the resultsdb_integration branch, not master. https://fedorahosted.org/reviewboard/r/259/
#408: depcheck: Argument list too long --------------------+-------------------------------- Reporter: kparal | Owner: jskladan Type: defect | Status: assigned Priority: minor | Milestone: Nice to have soon Component: tests | Resolution: Keywords: | Blocked By: Blocking: | --------------------+--------------------------------
Comment (by kparal):
Reviewed.
#408: depcheck: Argument list too long --------------------+-------------------------------- Reporter: kparal | Owner: jskladan Type: defect | Status: assigned Priority: minor | Milestone: Nice to have soon Component: tests | Resolution: Keywords: | Blocked By: Blocking: | --------------------+--------------------------------
Comment (by tflink):
Why use pickles for this and not something a bit more generic like a text file or yaml or something? I can see this being useful for running depcheck outside of AutoQA but using pickles to facilitate communication between two different pieces of code seems a bit odd to me.
#408: depcheck: Argument list too long --------------------+-------------------------------- Reporter: kparal | Owner: jskladan Type: defect | Status: assigned Priority: minor | Milestone: Nice to have soon Component: tests | Resolution: Keywords: | Blocked By: Blocking: | --------------------+--------------------------------
Comment (by jskladan):
tflink: because python-wise it's the easiest to use. I did not see any interest in running depheck out of AutoQA, but if you think it's realistic, I'll gladly discard pickle in favour to something else.
#408: depcheck: Argument list too long --------------------+-------------------------------- Reporter: kparal | Owner: jskladan Type: defect | Status: assigned Priority: minor | Milestone: Nice to have soon Component: tests | Resolution: Keywords: | Blocked By: Blocking: | --------------------+--------------------------------
Comment (by tflink):
Replying to [comment:4 jskladan]:
tflink: because python-wise it's the easiest to use. I did not see any
interest in running depheck out of AutoQA, but if you think it's realistic, I'll gladly discard pickle in favour to something else.
I don't really see other things using the files, no. It just seems a bit odd to be passing in pickles from the command line.
From your patch, it looks like there won't be any loss of functionality so I don't have any huge objections, though.
#408: depcheck: Argument list too long --------------------+----------------------- Reporter: kparal | Owner: jskladan Type: defect | Status: closed Priority: minor | Milestone: 0.8.0 Component: tests | Resolution: fixed Keywords: | Blocked By: Blocking: | --------------------+----------------------- Changes (by kparal):
* status: assigned => closed * resolution: => fixed * milestone: Nice to have soon => 0.8.0
Comment:
Fixed in 5f2b179
autoqa-devel@lists.fedorahosted.org