----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/3/ -----------------------------------------------------------
(Updated Feb. 12, 2013, 10:22 p.m.)
Review request for blockerbugs.
Changes -------
trying to trigger email notification of available review
Summary (updated) -----------------
Initial Support for FAS Authentication
Bugs: 335 https://fedorahosted.org/fedora-qa/ticket/335
Repository: blockerbugs
Description -------
Initial support for logins using FAS for authentication.
* The admin pages have been changed to check for membership in the FAS group 'qa-admin' instead of internal auth * auth is against admin.stg.fedoraproject.org instead of production FAS for DEV mode * apache configuration is changed to force SSL (mod_rewrite for now)
Diffs -----
runapp.py 34c5be0538baafa41b56f0f3d1105300c30a9956 requirements.txt 2728e4ac49a98c69d5b8f21d8a5c5fe42ab40172 conf/blockerbugs.conf a92f9d881810347d197b7f2bc5f3c2acdcb6a202 blockerbugs/templates/login.html 1d04e336c54d6ba731e49684b7d5b4db8d13f4a0 blockerbugs/templates/layout.html 3b1b6b625062d396b86cda89f40f7a5ba00d7a7d blockerbugs/controllers/users.py PRE-CREATION blockerbugs/controllers/admin.py 4a30f273ac515eaa7f75cda3050ac688cf60db2d blockerbugs/config.py 009e7a97f57e31fcc499dba87fe7d33e41252a2c blockerbugs/__init__.py ad051ca2523aa70ca2d4d26843e9a2bdf0b5cd00
Diff: http://reviewboard-tflink.rhcloud.com/r/3/diff/
Testing -------
I've tested mostly against admin.stg.fedoraproject.org but I've verified that the following do work: - logins - checking for membership before allowing access to admin pages
I don't have a FAS login to test for denying access to admin pages, though.
Thanks,
Tim Flink