Architecture specific change in rpms/eccodes.git - Arch-excludes - Fedora mailing-lists

9 May 2018

The package rpms/eccodes.git has added or updated architecture specific content in its
spec file (ExclusiveArch/ExcludeArch or %ifarch/%ifnarch) in commit(s):
https://src.fedoraproject.org/cgit/rpms/eccodes.git/commit/?id=9cab2c2bc3bb5...
https://src.fedoraproject.org/cgit/rpms/eccodes.git/commit/?id=56ad6fdf07097....
Change:
-ExcludeArch: armv7hl
+ExcludeArch: ppc64
Thanks.
Full change:
============
commit 75a9b2b9f9f068c17aecdf52f8dfc194888ca420
Author: Jos de Kloe josdekloe@gmail.com
Date:   Wed May 9 11:39:41 2018 +0200
add tar file for updated version 2.7.3

diff --git a/.gitignore b/.gitignore
index d15f2b0..c9bee99 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,2 +1,3 @@
 /eccodes-2.7.0-Source.tar.gz
 /eccodes_test_data.tar.gz
+/eccodes-2.7.3-Source.tar.gz
diff --git a/sources b/sources
index 27a0e6e..f1bdd17 100644
--- a/sources
+++ b/sources
@@ -1,2 +1 @@
-SHA512 (eccodes-2.7.0-Source.tar.gz) = 6b65902e0e82a038e6c705c68a5947ceef4f6950d83bdfcc78ec83b60bdcbc2b56a62971c5aa40c91b749c224ffa8ef120e9b72bf168032ffef9096207234103
-SHA512 (eccodes_test_data.tar.gz) = b0baa0867ac583ec9000e21b2653d11c26333a50bb817a41cad0ebc30b445fc9295f7b5cbc6908364aed502bfc4786929f2dcd0526b6540b26c1c024c90ede6a
+SHA512 (eccodes-2.7.3-Source.tar.gz) = a6ac6dae5a785a14e2b69ecc698e72f4173c96655c8944f6e6f1c530e72a078036c2fd76d77473e17b33be606ec36f8236a0efa22afc8b4d7760d88a053902f4
commit 9cab2c2bc3bb59f3a04a624da6ca4d03e60731b2
Author: Jos de Kloe josdekloe@gmail.com
Date:   Wed May 9 11:35:07 2018 +0200
upgrade to version 2.7.3
diff --git a/eccodes.spec b/eccodes.spec
index 0ccf629..fa49e86 100644
--- a/eccodes.spec
+++ b/eccodes.spec
@@ -1,16 +1,17 @@
 Name:           eccodes
-Version:        2.7.0
-Release:        2%{?dist}
+Version:        2.7.3
+Release:        1%{?dist}
 Summary:        WMO data format decoding and encoding
# force the shared libraries to have these so versions
 %global so_version       0.1
 %global so_version_f90   0.1
-# latest rawhide grib_api version is 1.25.0-4
+# latest rawhide grib_api version is 1.26.1-1
 # but this version number is to be updated as soon as we know
 # what the final release of grib_api by upstream will be.
-%global final_grib_api_version 1.25.0-4
+# latest upstream grib_api release is 1.26.1 (08-May-2018)
+%global final_grib_api_version 1.26.1-1
# license remarks:
 # most of eccodes is licensed ASL 2.0 but some special cases must be noted.
@@ -36,6 +37,7 @@ URL:            https://software.ecmwf.int/wiki/display/ECC/ecCodes+Home
 Source0:        https://software.ecmwf.int/wiki/download/attachments/45757960/eccodes-%%7Bve...
 # note: this data package is unversioned upstream but still it is updated
 # now and then. The current copy was downloaded 03-Jan-2018
+# (it was still the same on 08-May-2018)
 Source1:        http://download.ecmwf.org/test-data/grib_api/eccodes_test_data.tar.gz
 # Support 32-bit
 # https://software.ecmwf.int/issues/browse/SUP-1813
@@ -96,13 +98,13 @@ Requires: %{name}-data = %{version}-%{release}
 Obsoletes:      grib_api < %{final_grib_api_version}
# as explained in bugzilla #1562066
-ExcludeArch: i686
+#ExcludeArch: i686
 # as explained in bugzilla #1562071
-ExcludeArch: ppc64
+#ExcludeArch: ppc64
 # as explained in bugzilla #1562076
-ExcludeArch: s390x
+#ExcludeArch: s390x
 # as explained in bugzilla #1562084
-ExcludeArch: armv7hl
+#ExcludeArch: armv7hl
%description
 ecCodes is a package developed by ECMWF which provides an application
@@ -138,7 +140,7 @@ and behaviour. A significant difference compared with GRIB-API tools is that
 bufr_dump produces output in JSON format suitable for many web based
 applications.
-
+#####################################################
 %package devel
 Summary:    Contains ecCodes development files
 Requires:   %{name}%{?_isa} = %{version}-%{release}
@@ -150,7 +152,7 @@ Obsoletes:  grib_api-devel < %{final_grib_api_version}
 %description devel
 Header files and libraries for ecCodes.
-# note: python3 is not yet supported by eccodes
+#####################################################
 %package -n python2-%{name}
 Summary:    A python2 interface to ecCodes
 Requires:   %{name}%{?_isa} = %{version}-%{release}
@@ -163,6 +165,10 @@ Requires:   jasper-devel%{?_isa}
 %description -n python2-%{name}
 A python2 interface to ecCodes. Also a legacy interface to gribapi is provided.
+#####################################################
+# note: python3 is not yet supported by eccodes
+
+#####################################################
 %package data
 Summary:    Data needed by the eccodes library and tools
 BuildArch:  noarch
@@ -173,6 +179,7 @@ to encode and decode grib and bufr files, and includes
 both the official WMO tables and a number of often used
 local definitions by ECMWF and other meteorological centers.
+#####################################################
 %package doc
 Summary:    Documentation and example code
 BuildArch:  noarch
@@ -185,6 +192,7 @@ This package contains the html documentation for ecCodes
 and a fair number of example programs and scripts to use it
 in C, Fortran 90, and Python.
+#####################################################
 %prep
 %autosetup -n %{name}-%{version}-Source -p1
@@ -345,6 +353,11 @@ ctest -V %{?_smp_mflags}
 %doc %{_datadir}/doc/%{name}/
%changelog
+* Tue May 08 2018 Jos de Kloe josdekloe@gmail.com - 2.7.3-1
+- Upgrade to version 2.7.3
+- adjust latest grib_api version to 1.26.1-1
+- for now, try to disable ExcludeArch statements to see what happens
+
 * Thu Mar 29 2018 Jos de Kloe josdekloe@gmail.com - 2.7.0-2
 - added ExcludeArch statements for the failing architectures
commit 56ad6fdf070973d3705c549a7f99e02b3d0cee01
Author: Jos de Kloe josdekloe@gmail.com
Date:   Mon Apr 23 09:36:05 2018 +0200
add rpmlintrc and disable manual test runs
diff --git a/eccodes.rpmlintrc b/eccodes.rpmlintrc
new file mode 100644
index 0000000..60064d2
--- /dev/null
+++ b/eccodes.rpmlintrc
@@ -0,0 +1,56 @@
+# use like this:
+# rpmlint --file eccodes.rpmlintrc *.rpm
+# example: addFilter ("^foo-.*regex-match-for-rpmlint-warning")
+
+# these are invalid spelling warnings. GRIB and BUFR are correct, since these are
+# the names of the data files that this software handles.
+# the description itself is a 1-to-1 copy of what the (UK-based) upstream
+# writes, and I am not going to translate this to US spelling ...
+addFilter ("W: spelling-error %description -l en_US behaviour -> behavior")
+addFilter ("W: spelling-error %description -l en_US grib ->")
+addFilter ("W: spelling-error %description -l en_US bufr ->")
+
+# this data file with wrong line ending has been added to the software on purpose
+# for testing purposes, so this is no mistake
+addFilter ("eccodes-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/eccodes/examples/python/flight_data.csv")
+
+# these data files are no scripts. The dataformat just has an unfortunate first line
+# starting with #! so it resembles a shebang line.
+# see also comment #3 in the review request at https://bugzilla.redhat.com/show_bug.cgi?id=1508950
+addFilter ("^eccodes-data.noarch: E: wrong-script-interpreter /usr/share/eccodes/definitions/grib1/local.82.0.def")
+addFilter ("^eccodes-data.noarch: E: non-executable-script /usr/share/eccodes/definitions/grib1/local.82.0.def")
+addFilter ("^eccodes-data.noarch: E: wrong-script-interpreter /usr/share/eccodes/definitions/grib1/local.82.83.def")
+addFilter ("^eccodes-data.noarch: E: non-executable-script /usr/share/eccodes/definitions/grib1/local.82.83.def")
+
+# this is a false error (its an rpmlint bug).
+# the spec file now uses %ldconfig_scriptlets in stead of the old ldconfig-postin/postun
+# see also comment #18 in the review request at https://bugzilla.redhat.com/show_bug.cgi?id=1508950
+addFilter ("^eccodes.x86_64: E: library-without-ldconfig-postin /usr/lib64/libeccodes.so.0.1")
+addFilter ("^eccodes.x86_64: E: library-without-ldconfig-postun /usr/lib64/libeccodes.so.0.1")
+addFilter ("^eccodes.x86_64: E: library-without-ldconfig-postin /usr/lib64/libeccodes_f90.so.0.1")
+addFilter ("^eccodes.x86_64: E: library-without-ldconfig-postun /usr/lib64/libeccodes_f90.so.0.1")
+
+# this is an rpmlint bug
+# see also comment #8 in the review request at https://bugzilla.redhat.com/show_bug.cgi?id=1508950
+addFilter ("eccodes-debuginfo.x86_64: E: useless-provides debuginfo(build-id)")
+
+# there is no full compatibility between the old grib_api and the new eccodes
+# so only obsoletes can be used bu no provides.
+# see also comment #21 in the review request at https://bugzilla.redhat.com/show_bug.cgi?id=1508950
+addFilter ("^eccodes.x86_64: W: obsolete-not-provided grib_api")
+addFilter ("^eccodes-devel.x86_64: W: obsolete-not-provided grib_api-devel")
+addFilter ("^eccodes-devel.x86_64: W: only-non-binary-in-usr-lib")
+
+# documentation is in a dedicated doc subpackage,
+# so these warnings have no merit
+addFilter ("python2-eccodes.x86_64: W: no-documentation")
+addFilter ("eccodes-debugsource.x86_64: W: no-documentation")
+addFilter ("eccodes-devel.x86_64: W: no-documentation")
+addFilter ("eccodes-data.noarch: W: no-documentation")
+
+# temporary disable the man page warning, since it obscures other problems that
+# may be more important, and it has already been reported upstream
+# see also comment #3 in the review request at https://bugzilla.redhat.com/show_bug.cgi?id=1508950
+addFilter ("eccodes.x86_64: W: no-manual-page-for-binary")
+
+# addFilter ("")
diff --git a/eccodes.spec b/eccodes.spec
index 48678b0..0ccf629 100644
--- a/eccodes.spec
+++ b/eccodes.spec
@@ -98,7 +98,7 @@ Obsoletes:      grib_api < %{final_grib_api_version}
 # as explained in bugzilla #1562066
 ExcludeArch: i686
 # as explained in bugzilla #1562071
-# ExcludeArch: ppc64
+ExcludeArch: ppc64
 # as explained in bugzilla #1562076
 ExcludeArch: s390x
 # as explained in bugzilla #1562084
@@ -236,7 +236,6 @@ cd build
         -DECCODES_SOVERSION_F90=%{so_version_f90} \
         -DPYTHON_EXECUTABLE=%{_bindir}/python2 \
         ..
-# or: -DCMAKE_SKIP_RPATH=ON ??
%make_build
@@ -313,29 +312,9 @@ cd build
 # so a patch has been added to solve this for now.
 # See: https://software.ecmwf.int/issues/browse/SUP-1812
 # (unfortunately this issue is not public)
-#LD_LIBRARY_PATH=%{buildroot}/%{_libdir} \
-#LIBRARY_PATH=%{buildroot}/%{_libdir} \
-# ctest -V %{?_smp_mflags}
-
-# manually run some problematic tests for ppc64:
-#echo "================================="
-#echo "================================="
-#echo "================================="
-#echo "output for: ctest -VV -R t_optimize_scaling_sh"
-#echo "================================="
-#LD_LIBRARY_PATH=%{buildroot}/%{_libdir} \
-#LIBRARY_PATH=%{buildroot}/%{_libdir} \
-#ctest -VV -R t_optimize_scaling_sh
-echo "================================="
-echo "================================="
-echo "================================="
-echo "output for: ctest -VV -R t_bufr_dump_encode_fortran"
 LD_LIBRARY_PATH=%{buildroot}/%{_libdir} \
 LIBRARY_PATH=%{buildroot}/%{_libdir} \
-ctest -VV -R t_bufr_dump_encode_fortran
-echo "================================="
-echo "================================="
-echo "================================="
+ctest -V %{?_smp_mflags}
%files
 %license LICENSE

    