On 07/18/2014 02:50 PM, David Lehman wrote:
On 07/18/2014 03:21 AM, Artur Paszkiewicz wrote:
> On 07/18/2014 09:49 AM, Vratislav Podzimek wrote:
>> On Fri, 2014-07-18 at 09:32 +0200, Artur Paszkiewicz wrote:
>>> On 07/17/2014 05:30 PM, David Lehman wrote:
>>>> On 07/17/2014 06:39 AM, Artur Paszkiewicz wrote:
>>>>> Volumes which are not selected in Specialized Storage Devices are
>>>>> ignored in addUdevDevice. This causes that their parent container
>>>>> won't have its child counter incremented, which can later cause
an
>>>>> incorrect unusedRaidMembersWarning.
>>>>
>>>> Why would you not select all members/components of a container you plan
to use?
>>>
>>> I may not want to use some particular container for installation. There
>>> can be multiple containers on different disks. This results in a
>>> misleading warning, that "disks contain BIOS RAID metadata, but are not
>>> part of any recognized BIOS RAID sets". This is not true - the RAID
>>> arrays are assembled and recognized, just not selected in the installer.
>> But only if you select some devices from the container for installation,
>> right? That's seems like a situation dangerous enough to show a warning
>> even if a bit misleading.
>
> No, this happens when I don't select any devices (BIOS RAID sets) from
> the container. I can't see why this could be dangerous. I'm not
> selecting any of the component disks of the container, in fact they are
But what if you were selecting one of them? This patch would disable a valid warning.
My take is that we shouldn't be showing a warning about a fwraid array on unselected
disks. Rather than lie about what we've found, we should be more careful about what
conditions we warn under.
I see it this way, that this patch does not really disable the warning,
but it tries to workaround a problem with MD RAID arrays detection:
- a MD container is never ignored
- a MD volume which belongs to a container is ignored when it is not
selected, and its container's child counter won't be incremented
The warning is displayed for containers having kids == 0, so I get a
warning about unrecognized BIOS RAID sets, even though they are
recognized, just not selected for use.
For a container, which really does not have any recognized volumes, not
visible in the Firmware RAID tab, the warning is still displayed (I've
tested this). I believe that this is the way it was supposed to work,
please correct me if I'm wrong.
Artur
David
> not even shown on any of the tabs, so they must be properly identified
> as RAID component devices. Here are the steps to reproduce this:
>
> 1. Create 2 IMSM RAID arrays on different disks
> 2. Run the RHEL installer
> 3. Select "Specialized Storage Devices"
> 4. On the "Firmware RAID" tab select only one RAID array and click
> "Next"
>
> Artur