Top 4 here: https://github.com/projectatomic/anaconda/tree/rhel-7.0-atomic
I know they're not against master, but if they can get a quick review pass before I do the rebasing that'd be great.
Well, top 5 because the initial rpmostreepayload+GRUB2 one was ACK'd by bcl but not pushed yet AFAICS.
Quick reviewing, they look OK to me, I think they want second eye, posting patches in the form used on the list could help getting it.
On 10/20/2014 10:39 PM, Colin Walters wrote:
Top 4 here: https://github.com/projectatomic/anaconda/tree/rhel-7.0-atomic
I know they're not against master, but if they can get a quick review pass before I do the rebasing that'd be great. _______________________________________________ anaconda-patches mailing list anaconda-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
On Mon, Oct 20, 2014 at 04:39:11PM -0400, Colin Walters wrote:
Top 4 here: https://github.com/projectatomic/anaconda/tree/rhel-7.0-atomic
I know they're not against master, but if they can get a quick review pass before I do the rebasing that'd be great.
A few small comments:
rpmostreepayload: Rework remote add handling line 153 - drop using sysroot_path and just use self._sysroot_path everywhere.after.
Added an extra empty line @ 298.
Everything else looks just fine.
On Tue, Oct 21, 2014, at 01:19 PM, Brian C. Lane wrote:
rpmostreepayload: Rework remote add handling line 153 - drop using sysroot_path and just use self._sysroot_path everywhere.after.
Added an extra empty line @ 298.
Fixed both of these and force pushed; is that enough or do you want them extracted to the list as well? Remember I don't have commit access.
Fixed both of these and force pushed; is that enough or do you want them extracted to the list as well? Remember I don't have commit access.
For a small number of patches like this, it's easy enough to just extract patches from github and apply them manually. If it was a lot of patches, I'd ask you to do that part for me.
- Chris
On Tue, Oct 21, 2014, at 04:43 PM, Chris Lumens wrote:
I know they're not against master, but if they can get a quick review pass before I do the rebasing that'd be great.
If you can rebase against what's current in rhel7-branch (and then we'll have to deal with master too), I'll go ahead and apply them.
I pushed to https://github.com/projectatomic/anaconda/tree/rhel7-branch
(Compile tested only)
anaconda-patches@lists.fedorahosted.org