On Tue, Jun 26, 2012 at 04:01:08PM -0400, Will Woods wrote:
On Tue, 2012-06-26 at 11:48 -0700, Brian C. Lane wrote:
> From: "Brian C. Lane" <bcl(a)redhat.com>
>
> If a kickstart pre/post fails we read the logfile and add it to the
> anaconda log. This doesn't work well for device nodes like /dev/console
> so skip reading if it is a device node.
Not super-happy with the path check; what if we're looking
at /run/sysroot/dev or something?
Why not just check to see if it's a regular file or not? e.g.:
if not os.path.isfile(self.logfile):
os.path.isfile() should return true for regular files and symbolic links
to regular files; everything else will be false. I think that's the
behavior we'd want?
Good idea!
--
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)