On 03/14/2013 02:47 PM, Martin Sivak wrote:
the first two patches are quite simple and not at all special.
However
the other two are something I had to do to, but it might not be the
best way with regards to anaconda future and maintenance.
3) This patch implements the feature Stef asked for his realmd addon
- he was affraid that customers will regard %addon section in kickstart
as something that is not really supported that well
- so he asked us to look into allowing the addons to define their own
"first class" kickstart command that will not be distinguishable from
the rest
- I see two issues with it. One is validation, and the second is that
when addon is missing, sections are gracefully saved and transfered to
the output kickstart without breaking anaconda. Unknown command raises
an exception.
- Regarding validation.. the whole kickstart addon implementation should
be moved to pykickstart so the validation tools can load the addons as
well.
Thanks for working on this patch Martin,
I'd like to underscore this again, since there has been no response here
(nor did I find this patch in git master).
Although I'm fine with implementing certain Fedora and RHEL features as
addons for maintenance reasons, it is vital that features like the
Active Directory integration do not look like addons to users and
customers, but rather a core part of a the RHEL product.
As an alternative, without this capability, we're going to have to move
toward making the realmd integration be integrated directly into
anaconda and not as an addon.
If the addon support is not mature enough to support real proper
integrated commands, (with kickstart validation support and so on) at
this point, then it is not mature enough for the realmd work.
Chris or David, would you be able to make a call here? This has been
discussed on and off for months between several of us, but now we need
to actually make a decision whether addons are to be useful for such
core features of Fedora and RHEL.
For reference, without this patch the realmd integration looks like:
%addon org.fedora.realm
realm join --one-time-password=blah
mydomain.com
%end
And with the patch it looks as expected, a single command:
realm join --one-time-paswsord=blah
mydomain.com
Thanks in advance,
Stef