--- pyanaconda/ui/gui/spokes/custom.glade | 9 +++++++++ 1 file changed, 9 insertions(+)
diff --git a/pyanaconda/ui/gui/spokes/custom.glade b/pyanaconda/ui/gui/spokes/custom.glade index e26129a..81938e9 100644 --- a/pyanaconda/ui/gui/spokes/custom.glade +++ b/pyanaconda/ui/gui/spokes/custom.glade @@ -3,6 +3,15 @@ <interface> <!-- interface-requires gtk+ 3.2 --> <!-- interface-requires AnacondaWidgets 1.0 --> + <object class="GtkListStore" id="mountPointStore"> + <columns> + <!-- column-name path --> + <column type="gchararray"/> + </columns> + </object> + <object class="GtkEntryCompletion" id="mountPointCompletion"> + <property name="model">mountPointStore</property> + </object> <object class="AnacondaSpokeWindow" id="customStorageWindow"> <property name="can_focus">False</property> <property name="events">GDK_KEY_RELEASE_MASK | GDK_STRUCTURE_MASK</property>
On 03/18/2014 02:40 PM, Chris Lumens wrote:
pyanaconda/ui/gui/spokes/custom.glade | 9 +++++++++ 1 file changed, 9 insertions(+)
diff --git a/pyanaconda/ui/gui/spokes/custom.glade b/pyanaconda/ui/gui/spokes/custom.glade index e26129a..81938e9 100644 --- a/pyanaconda/ui/gui/spokes/custom.glade +++ b/pyanaconda/ui/gui/spokes/custom.glade @@ -3,6 +3,15 @@
<interface> <!-- interface-requires gtk+ 3.2 --> <!-- interface-requires AnacondaWidgets 1.0 --> + <object class="GtkListStore" id="mountPointStore"> + <columns> + <!-- column-name path --> + <column type="gchararray"/> + </columns> + </object> + <object class="GtkEntryCompletion" id="mountPointCompletion"> + <property name="model">mountPointStore</property> + </object> <object class="AnacondaSpokeWindow" id="customStorageWindow"> <property name="can_focus">False</property> <property name="events">GDK_KEY_RELEASE_MASK | GDK_STRUCTURE_MASK</property>
Ack. Maybe it would be worthwhile to add some of these ID references to the glade validity check.
On Tue, 2014-03-18 at 14:40 -0400, Chris Lumens wrote:
pyanaconda/ui/gui/spokes/custom.glade | 9 +++++++++ 1 file changed, 9 insertions(+)
diff --git a/pyanaconda/ui/gui/spokes/custom.glade b/pyanaconda/ui/gui/spokes/custom.glade index e26129a..81938e9 100644 --- a/pyanaconda/ui/gui/spokes/custom.glade +++ b/pyanaconda/ui/gui/spokes/custom.glade @@ -3,6 +3,15 @@
<interface> <!-- interface-requires gtk+ 3.2 --> <!-- interface-requires AnacondaWidgets 1.0 --> + <object class="GtkListStore" id="mountPointStore"> + <columns> + <!-- column-name path --> + <column type="gchararray"/> + </columns> + </object> + <object class="GtkEntryCompletion" id="mountPointCompletion"> + <property name="model">mountPointStore</property> + </object> <object class="AnacondaSpokeWindow" id="customStorageWindow"> <property name="can_focus">False</property> <property name="events">GDK_KEY_RELEASE_MASK | GDK_STRUCTURE_MASK</property>
NACK. The custom spoke actually doesn't need those two objects. They were incorrectly listed in the builderObjects list. Sending a new patch.
On 03/19/2014 03:41 AM, Vratislav Podzimek wrote:
On Tue, 2014-03-18 at 14:40 -0400, Chris Lumens wrote:
pyanaconda/ui/gui/spokes/custom.glade | 9 +++++++++ 1 file changed, 9 insertions(+)
diff --git a/pyanaconda/ui/gui/spokes/custom.glade b/pyanaconda/ui/gui/spokes/custom.glade index e26129a..81938e9 100644 --- a/pyanaconda/ui/gui/spokes/custom.glade +++ b/pyanaconda/ui/gui/spokes/custom.glade @@ -3,6 +3,15 @@
<interface> <!-- interface-requires gtk+ 3.2 --> <!-- interface-requires AnacondaWidgets 1.0 --> + <object class="GtkListStore" id="mountPointStore"> + <columns> + <!-- column-name path --> + <column type="gchararray"/> + </columns> + </object> + <object class="GtkEntryCompletion" id="mountPointCompletion"> + <property name="model">mountPointStore</property> + </object> <object class="AnacondaSpokeWindow" id="customStorageWindow"> <property name="can_focus">False</property> <property name="events">GDK_KEY_RELEASE_MASK | GDK_STRUCTURE_MASK</property>
NACK. The custom spoke actually doesn't need those two objects. They were incorrectly listed in the builderObjects list. Sending a new patch.
If that's the case then there's also a problem with this in custom.glade:
<object class="GtkEntry" id="mountPointEntry"> <property name="visible">True</property> <property name="can_focus">True</property> <property name="hexpand">True</property> <property name="invisible_char">●</property> <property name="completion">mountPointCompletion</property> <signal name="changed" handler="on_value_changed" swapped="no"/> </object>
On Wed, 2014-03-19 at 10:14 -0400, David Shea wrote:
On 03/19/2014 03:41 AM, Vratislav Podzimek wrote:
On Tue, 2014-03-18 at 14:40 -0400, Chris Lumens wrote:
pyanaconda/ui/gui/spokes/custom.glade | 9 +++++++++ 1 file changed, 9 insertions(+)
diff --git a/pyanaconda/ui/gui/spokes/custom.glade b/pyanaconda/ui/gui/spokes/custom.glade index e26129a..81938e9 100644 --- a/pyanaconda/ui/gui/spokes/custom.glade +++ b/pyanaconda/ui/gui/spokes/custom.glade @@ -3,6 +3,15 @@
<interface> <!-- interface-requires gtk+ 3.2 --> <!-- interface-requires AnacondaWidgets 1.0 --> + <object class="GtkListStore" id="mountPointStore"> + <columns> + <!-- column-name path --> + <column type="gchararray"/> + </columns> + </object> + <object class="GtkEntryCompletion" id="mountPointCompletion"> + <property name="model">mountPointStore</property> + </object> <object class="AnacondaSpokeWindow" id="customStorageWindow"> <property name="can_focus">False</property> <property name="events">GDK_KEY_RELEASE_MASK | GDK_STRUCTURE_MASK</property>
NACK. The custom spoke actually doesn't need those two objects. They were incorrectly listed in the builderObjects list. Sending a new patch.
If that's the case then there's also a problem with this in custom.glade:
<object class="GtkEntry"
id="mountPointEntry"> <property name="visible">True</property> <property name="can_focus">True</property> <property name="hexpand">True</property> <property name="invisible_char">●</property> <property name="completion">mountPointCompletion</property> <signal name="changed" handler="on_value_changed" swapped="no"/> </object>
Ahh, okay, you are right, guys, I've overlooked this. The first (clumens') patch is the right one, than. Apologies
Signed-off-by: Vratislav Podzimek vpodzime@redhat.com --- pyanaconda/ui/gui/spokes/custom.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/pyanaconda/ui/gui/spokes/custom.py b/pyanaconda/ui/gui/spokes/custom.py index 42ec171..8acf1e1 100644 --- a/pyanaconda/ui/gui/spokes/custom.py +++ b/pyanaconda/ui/gui/spokes/custom.py @@ -125,8 +125,7 @@ partition_only_format_types = ["efi", "macefi", "prepboot", "biosboot", class CustomPartitioningSpoke(NormalSpoke, StorageChecker): builderObjects = ["customStorageWindow", "containerStore", "partitionStore", "raidStoreFiltered", "raidLevelStore", - "addImage", "removeImage", "settingsImage", - "mountPointCompletion", "mountPointStore"] + "addImage", "removeImage", "settingsImage",] mainWidgetName = "customStorageWindow" uiFile = "spokes/custom.glade"
anaconda-patches@lists.fedorahosted.org