New subject: [PATCH 1/5] Require that the root filesystem be created by anaconda.
There is kickstart and fsprofile/mke2fs.conf for those with special
requirements for filesystem creation parameters.
---
pyanaconda/storage/__init__.py | 5 +++++
pyanaconda/ui/gui/spokes/custom.py | 2 ++
2 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/pyanaconda/storage/__init__.py b/pyanaconda/storage/__init__.py
index 0726a1c..ff930cf 100644
--- a/pyanaconda/storage/__init__.py
+++ b/pyanaconda/storage/__init__.py
@@ -1605,6 +1605,11 @@ class Storage(object):
if mountpoint in mustbeonlinuxfs and (not dev.format.mountable or not
dev.format.linuxNative):
errors.append(_("The mount point %s must be on a linux file
system.") % mountpoint)
+ if self.rootDevice and self.rootDevice.format.exists:
+ e = self.mustFormat(self.rootDevice)
+ if e:
+ errors.append(e)
+
return (errors, warnings)
def isProtected(self, device):
diff --git a/pyanaconda/ui/gui/spokes/custom.py b/pyanaconda/ui/gui/spokes/custom.py
index dac54bb..a134c2a 100644
--- a/pyanaconda/ui/gui/spokes/custom.py
+++ b/pyanaconda/ui/gui/spokes/custom.py
@@ -959,6 +959,8 @@ class CustomPartitioningSpoke(NormalSpoke, StorageChecker):
error = _("%s cannot be encrypted") % mountpoint
elif encrypted and fs_type_short in partition_only_format_types:
error = _("%s cannot be encrypted") % fs_type
+ elif mountpoint == "/" and device.format.exists and not reformat:
+ error = _("You must create a new filesystem on the root device.")
if error:
self.window.set_info(Gtk.MessageType.WARNING, error)
--
1.7.7.6
New subject: [PATCH 2/5] Remove the word "review" from the label on the custom checkbutton.
There's nothing to review. It's not "run autopart and then review it",
it's more like "skip autopart and go to custom".
---
pyanaconda/ui/gui/spokes/storage.glade | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/pyanaconda/ui/gui/spokes/storage.glade
b/pyanaconda/ui/gui/spokes/storage.glade
index 16ce58b..a33a026 100644
--- a/pyanaconda/ui/gui/spokes/storage.glade
+++ b/pyanaconda/ui/gui/spokes/storage.glade
@@ -239,7 +239,7 @@
</child>
<child>
<object class="GtkCheckButton"
id="options2_custom_check">
- <property name="label" translatable="yes">I
don't need help; let me _review & customize disk partitioning to reclaim
space.</property>
+ <property name="label" translatable="yes">I
don't need help; let me customize disk _partitioning.</property>
<property name="visible">True</property>
<property name="can_focus">True</property>
<property name="receives_default">False</property>
--
1.7.7.6
New subject: [PATCH 4/5] Fix a traceback when removing non-existing partitions in custom. (#869839)
---
pyanaconda/ui/gui/spokes/custom.py | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/pyanaconda/ui/gui/spokes/custom.py b/pyanaconda/ui/gui/spokes/custom.py
index a134c2a..a638d62 100644
--- a/pyanaconda/ui/gui/spokes/custom.py
+++ b/pyanaconda/ui/gui/spokes/custom.py
@@ -1693,7 +1693,8 @@ class CustomPartitioningSpoke(NormalSpoke, StorageChecker):
# If we've just removed the last partition and the disklabel is pre-
# existing, reinitialize the disk.
- if device.type == "partition" and device.disk.format.exists:
+ if device.type == "partition" and device.exists and \
+ device.disk.format.exists:
with ui_storage_logger():
if self.__storage.shouldClear(device.disk):
self.__storage.initializeDisk(device.disk)
--
1.7.7.6