"Selected disks", "configure mountpoint", and "configure volume
group"
now show all the same information. Was "ID" ever a useful column to show
in "configure volume group"? It seems like enough useful info to distinguish
devices can be found from just device description, etc.
So removed "ID" column from "configure volume group" and added
"Name"
column. Also changed "Disk" -> "Description" (since that's
what is shown).
You can see the before/after here:
http://sbueno.fedorapeople.org/1289577-before.png
http://sbueno.fedorapeople.org/1289577-after.jpg
Resolves: rhbz#12289577
---
.../ui/gui/spokes/lib/custom_storage_helpers.glade | 26 +++++++++++-----------
.../ui/gui/spokes/lib/custom_storage_helpers.py | 2 +-
2 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/pyanaconda/ui/gui/spokes/lib/custom_storage_helpers.glade
b/pyanaconda/ui/gui/spokes/lib/custom_storage_helpers.glade
index af20996..0b2119d 100644
--- a/pyanaconda/ui/gui/spokes/lib/custom_storage_helpers.glade
+++ b/pyanaconda/ui/gui/spokes/lib/custom_storage_helpers.glade
@@ -712,7 +712,7 @@ use. Try something else?</property>
<child>
<object class="GtkTreeViewColumn"
id="disk_column1">
<property name="spacing">6</property>
- <property name="title"
translatable="yes">Disk</property>
+ <property name="title"
translatable="yes">Description</property>
<property name="clickable">True</property>
<child>
<object class="GtkCellRendererText"
id="disk_renderer1"/>
@@ -723,40 +723,40 @@ use. Try something else?</property>
</object>
</child>
<child>
- <object class="GtkTreeViewColumn"
id="capacity_column1">
+ <object class="GtkTreeViewColumn"
id="name_column1">
<property name="spacing">6</property>
- <property name="title"
translatable="yes">Capacity</property>
+ <property name="title"
translatable="yes">Name</property>
<property name="clickable">True</property>
<child>
- <object class="GtkCellRendererText"
id="capacity_renderer1"/>
+ <object class="GtkCellRendererText"
id="name_renderer1"/>
<attributes>
- <attribute name="text">1</attribute>
+ <attribute name="text">3</attribute>
</attributes>
</child>
</object>
</child>
<child>
- <object class="GtkTreeViewColumn"
id="free_column1">
+ <object class="GtkTreeViewColumn"
id="capacity_column1">
<property name="spacing">6</property>
- <property name="title"
translatable="yes">Free</property>
+ <property name="title"
translatable="yes">Capacity</property>
<property name="clickable">True</property>
<child>
- <object class="GtkCellRendererText"
id="free_renderer1"/>
+ <object class="GtkCellRendererText"
id="capacity_renderer1"/>
<attributes>
- <attribute name="text">2</attribute>
+ <attribute name="text">1</attribute>
</attributes>
</child>
</object>
</child>
<child>
- <object class="GtkTreeViewColumn"
id="id_column1">
+ <object class="GtkTreeViewColumn"
id="free_column1">
<property name="spacing">6</property>
- <property name="title"
translatable="yes">ID</property>
+ <property name="title"
translatable="yes">Free</property>
<property name="clickable">True</property>
<child>
- <object class="GtkCellRendererText"
id="id_renderer1"/>
+ <object class="GtkCellRendererText"
id="free_renderer1"/>
<attributes>
- <attribute name="text">3</attribute>
+ <attribute name="text">2</attribute>
</attributes>
</child>
</object>
diff --git a/pyanaconda/ui/gui/spokes/lib/custom_storage_helpers.py
b/pyanaconda/ui/gui/spokes/lib/custom_storage_helpers.py
index e095fee..8a7ebd0 100644
--- a/pyanaconda/ui/gui/spokes/lib/custom_storage_helpers.py
+++ b/pyanaconda/ui/gui/spokes/lib/custom_storage_helpers.py
@@ -476,7 +476,7 @@ class ContainerDialog(GUIObject, GUIDialogInputCheckHandler):
self._store.append([getDiskDescription(disk),
str(disk.size),
str(free[disk.name][0]),
- disk.serial,
+ disk.name,
disk.id])
model = self._treeview.get_model()
--
2.4.3