Prevent users from creating/using layouts that the bootloader tools do not support.
--- pyanaconda/bootloader.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/pyanaconda/bootloader.py b/pyanaconda/bootloader.py index 51f7f24..fcb9c4a 100644 --- a/pyanaconda/bootloader.py +++ b/pyanaconda/bootloader.py @@ -1349,8 +1349,7 @@ class GRUB2(GRUB): terminal_type = "console"
# requirements for boot devices - stage2_device_types = ["partition", "mdarray", "lvmlv", "btrfs volume", - "btrfs subvolume"] + stage2_device_types = ["partition", "mdarray", "lvmlv", "btrfs volume"] stage2_raid_levels = [mdraid.RAID0, mdraid.RAID1, mdraid.RAID4, mdraid.RAID5, mdraid.RAID6, mdraid.RAID10] stage2_raid_metadata = ["0", "0.90", "1.0", "1.2"]
On Tue, Dec 03, 2013 at 10:55:02AM -0600, David Lehman wrote:
pyanaconda/bootloader.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/pyanaconda/bootloader.py b/pyanaconda/bootloader.py index 51f7f24..fcb9c4a 100644 --- a/pyanaconda/bootloader.py +++ b/pyanaconda/bootloader.py @@ -1349,8 +1349,7 @@ class GRUB2(GRUB): terminal_type = "console"
# requirements for boot devices
- stage2_device_types = ["partition", "mdarray", "lvmlv", "btrfs volume",
"btrfs subvolume"]
- stage2_device_types = ["partition", "mdarray", "lvmlv", "btrfs volume"] stage2_raid_levels = [mdraid.RAID0, mdraid.RAID1, mdraid.RAID4, mdraid.RAID5, mdraid.RAID6, mdraid.RAID10] stage2_raid_metadata = ["0", "0.90", "1.0", "1.2"]
-- 1.8.1.4
Ack Ack.
On 12/03/2013 11:55 AM, David Lehman wrote:
pyanaconda/bootloader.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/pyanaconda/bootloader.py b/pyanaconda/bootloader.py index 51f7f24..fcb9c4a 100644 --- a/pyanaconda/bootloader.py +++ b/pyanaconda/bootloader.py @@ -1349,8 +1349,7 @@ class GRUB2(GRUB): terminal_type = "console"
# requirements for boot devices
- stage2_device_types = ["partition", "mdarray", "lvmlv", "btrfs volume",
"btrfs subvolume"]
- stage2_device_types = ["partition", "mdarray", "lvmlv", "btrfs volume"] stage2_raid_levels = [mdraid.RAID0, mdraid.RAID1, mdraid.RAID4, mdraid.RAID5, mdraid.RAID6, mdraid.RAID10] stage2_raid_metadata = ["0", "0.90", "1.0", "1.2"]
Close but not a winner. grubby does not like /boot being anywhere near a btrfs filesystem. While you may have disallowed /boot as a btrfs subvolume, it still installs and then boots up with /boot simply being a directory on the rootfs.
Took your patches and created an updates image against anaconda-20.25.13-1. Booted up TC4 and applied the updates to perform a kickstart install with only a regular partition defined for swap and /boot as a simple directory on the rootfs subvol.
Curious, you removed the btrfs subvolume but left in btrfs volume. I do not understand why you would ever install into a btrfs volume. Then again, maybe this let the /boot as a directory work.
I did not but will test /boot being a directory on the rootfs LVM.
Gene
I am going
On 12/03/2013 11:55 AM, David Lehman wrote:
pyanaconda/bootloader.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/pyanaconda/bootloader.py b/pyanaconda/bootloader.py index 51f7f24..fcb9c4a 100644 --- a/pyanaconda/bootloader.py +++ b/pyanaconda/bootloader.py @@ -1349,8 +1349,7 @@ class GRUB2(GRUB): terminal_type = "console"
# requirements for boot devices
- stage2_device_types = ["partition", "mdarray", "lvmlv", "btrfs volume",
"btrfs subvolume"]
- stage2_device_types = ["partition", "mdarray", "lvmlv", "btrfs volume"] stage2_raid_levels = [mdraid.RAID0, mdraid.RAID1, mdraid.RAID4, mdraid.RAID5, mdraid.RAID6, mdraid.RAID10] stage2_raid_metadata = ["0", "0.90", "1.0", "1.2"]
I am able to easy boot directly into a /boot directory on a btrfs / subvol on a btrfs fs. Hopefully this patch will not eliminate that.
On Tue, 2013-12-03 at 18:42 -0500, Clyde E. Kunkel wrote:
On 12/03/2013 11:55 AM, David Lehman wrote:
pyanaconda/bootloader.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/pyanaconda/bootloader.py b/pyanaconda/bootloader.py index 51f7f24..fcb9c4a 100644 --- a/pyanaconda/bootloader.py +++ b/pyanaconda/bootloader.py @@ -1349,8 +1349,7 @@ class GRUB2(GRUB): terminal_type = "console"
# requirements for boot devices
- stage2_device_types = ["partition", "mdarray", "lvmlv", "btrfs volume",
"btrfs subvolume"]
- stage2_device_types = ["partition", "mdarray", "lvmlv", "btrfs volume"] stage2_raid_levels = [mdraid.RAID0, mdraid.RAID1, mdraid.RAID4, mdraid.RAID5, mdraid.RAID6, mdraid.RAID10] stage2_raid_metadata = ["0", "0.90", "1.0", "1.2"]
I am able to easy boot directly into a /boot directory on a btrfs / subvol on a btrfs fs. Hopefully this patch will not eliminate that.
For crying out loud. Someone needs to make a list of what is and is not expected to work so I can make a damn patch. Please.
On 12/03/2013 07:02 PM, David Lehman wrote:
On Tue, 2013-12-03 at 18:42 -0500, Clyde E. Kunkel wrote:
On 12/03/2013 11:55 AM, David Lehman wrote:
pyanaconda/bootloader.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/pyanaconda/bootloader.py b/pyanaconda/bootloader.py index 51f7f24..fcb9c4a 100644 --- a/pyanaconda/bootloader.py +++ b/pyanaconda/bootloader.py @@ -1349,8 +1349,7 @@ class GRUB2(GRUB): terminal_type = "console"
# requirements for boot devices
- stage2_device_types = ["partition", "mdarray", "lvmlv", "btrfs volume",
"btrfs subvolume"]
- stage2_device_types = ["partition", "mdarray", "lvmlv", "btrfs volume"] stage2_raid_levels = [mdraid.RAID0, mdraid.RAID1, mdraid.RAID4, mdraid.RAID5, mdraid.RAID6, mdraid.RAID10] stage2_raid_metadata = ["0", "0.90", "1.0", "1.2"]
I am able to easy boot directly into a /boot directory on a btrfs / subvol on a btrfs fs. Hopefully this patch will not eliminate that.
For crying out loud. Someone needs to make a list of what is and is not expected to work so I can make a damn patch. Please.
Really? Don't you know? You are making the patch. Follow the spec for crying out loud. There is one, right? All I can do is test and report.
For crying out loud. Someone needs to make a list of what is and is not expected to work so I can make a damn patch. Please.
I believe we as a team have decided that btrfs+/boot is just too fraught with problems to support, so just push it.
- Chris
On 12/04/2013 09:42 AM, Chris Lumens wrote:
For crying out loud. Someone needs to make a list of what is and is not expected to work so I can make a damn patch. Please.
I believe we as a team have decided that btrfs+/boot is just too fraught with problems to support, so just push it.
- Chris
anaconda-patches mailing list anaconda-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
Ok, so you guys are no fun :-) How are we going to have any fun with this now? Plain vanilla booting is just sooooo boring.
BTW, what is supposed to work beside booting from plain ext4 partitions?
--- pyanaconda/bootloader.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pyanaconda/bootloader.py b/pyanaconda/bootloader.py index fcb9c4a..c820ae0 100644 --- a/pyanaconda/bootloader.py +++ b/pyanaconda/bootloader.py @@ -1349,7 +1349,7 @@ class GRUB2(GRUB): terminal_type = "console"
# requirements for boot devices - stage2_device_types = ["partition", "mdarray", "lvmlv", "btrfs volume"] + stage2_device_types = ["partition", "mdarray", "btrfs volume"] stage2_raid_levels = [mdraid.RAID0, mdraid.RAID1, mdraid.RAID4, mdraid.RAID5, mdraid.RAID6, mdraid.RAID10] stage2_raid_metadata = ["0", "0.90", "1.0", "1.2"]
On 12/03/2013 11:55 AM, David Lehman wrote:
Prevent users from creating/using layouts that the bootloader tools do not support. _______________________________________________ anaconda-patches mailing list anaconda-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
Are there plans to support these in the next release?
TIA
On Tue, 2013-12-03 at 10:55 -0600, David Lehman wrote:
Prevent users from creating/using layouts that the bootloader tools do not support.
ACK to both of these. Unless we have a clear reliable list of supported features of the boot loaders and related tools, there's nothing better we can do.
anaconda-patches@lists.fedorahosted.org