On Mon, Apr 29, 2013 at 12:47:06PM +0200, Vratislav Podzimek wrote:
On Fri, 2013-04-26 at 11:06 -0400, David Cantrell wrote:
> Similar to hfsplus, conditionalize out this BuildRequire so it is not in
> effect on RHEL systems.
> ---
> anaconda.spec.in | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/anaconda.spec.in b/anaconda.spec.in
> index ffe6075..1af34e2 100644
> --- a/anaconda.spec.in
> +++ b/anaconda.spec.in
> @@ -91,7 +91,9 @@ Requires: firewalld >= %{firewalldver}
> Requires: util-linux >= %{utillinuxver}
> Requires: dbus-python
> Requires: python-pwquality
> +%if ! 0%{?rhel}
> Requires: python-bugzilla
> +%endif
> Requires: python-IPy
> Requires: python-nss
> Requires: tigervnc-server-minimal
Looks good to me, but anybody knows why we need python-bugzilla as
"Requires"? Shouldn't it be "BuildRequires"?
It should technically be a BuildRequires, but even that way it would still
impose a requirement on what needs to be in RHEL-7. Which is the goal of
conditionalizing it out. I can change it to BuildRequires so it's more
accurate.
Thanks,
--
David Cantrell <dcantrell(a)redhat.com>
Manager, Installer Engineering Team
Red Hat, Inc. | Westford, MA | EST5EDT