On Tue, 2014-07-08 at 09:42 -0400, David Shea wrote:
Greetings, people of the past! I come to you with news from the
future.
I installed the latest devel version of pylint on my system to work on
what turned into a kind of complicated pull request to catch that
invalid list index thing (which still wouldn't have caught the one we
actually had, sadface), so here is what we can expect in upcoming versions:
pylint reports the following issues:
************* Module pyanaconda/ui/gui/spokes/lib/passphrase.py
W0713:114,30: PassphraseDialog._update_passphrase_strength: Indexing
exceptions will not work on Python 3
************* Module scripts/makebumpver
W0640:241,58: MakeBumpVer._rpmLog.<lambda>: Cell variable commit defined
in loop
************* Module pyanaconda/ui/__init__.py
W0640:179,94: UserInterface._orderActionClasses.<lambda>: Cell variable
hub defined in loop
W0640:182,95: UserInterface._orderActionClasses.<lambda>: Cell variable
hub defined in loop
************* Module pyanaconda/rescue.py
W0703:430,15: doRescue: Catching too general exception Exception
************* Module pyanaconda/users.py
W0713:171,22: validatePassword: Indexing exceptions will not work on
Python 3
************* Module pyanaconda/ui/tui/simpleline/base.py
W0703:286,19: App._do_redraw: Catching too general exception Exception
W0703:345,23: App._mainloop: Catching too general exception Exception
W0703:402,27: App.process_events: Catching too general exception Exception
W0703:440,19: App.input: Catching too general exception Exception
The Indexing exceptions warnings are both on pwquality.PWQError
exceptions, and indexing is the only way we can use them. So if
libpwquality ever supports Python 3, presumably this will change, but
for now we need to just ignore the warnings.
libpwquality should already be in a
process of adding Python3
compatibility.
The Cell variable <var> defined in loop are warning us that we're using
a loop variable in a closure, but in all three cases the closure is
within the loop too so who cares.
I think we should change those to list
comprehensions instead of using filter(..., lambda...).
I guess we might want to do about the Exception ones.
In some
cases these are necessary in order to keep the exception
handling working at least at the level it is now.
--
Vratislav Podzimek
Anaconda Rider | RHCE | Red Hat, Inc. | Brno - Czech Republic