From: "Brian C. Lane" bcl@redhat.com
--- pyanaconda/ui/gui/spokes/custom.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/pyanaconda/ui/gui/spokes/custom.py b/pyanaconda/ui/gui/spokes/custom.py index da2808c..dfda5dc 100644 --- a/pyanaconda/ui/gui/spokes/custom.py +++ b/pyanaconda/ui/gui/spokes/custom.py @@ -541,7 +541,7 @@ class ContainerDialog(GUIObject):
selected_level_string = store[itr][0] # eg: "RAID1 (Redundancy)" level = selected_level_string.split()[0].lower() # -> "raid1" - if level == "none": + if level == "none" or level == _("None").lower(): level = None
return level @@ -557,7 +557,7 @@ class ContainerDialog(GUIObject):
raid_level = self.raid_level if not raid_level or raid_level == "single": - raid_level = "None" + raid_level = _("None")
# Set a default RAID level in the combo. for (i, row) in enumerate(raid_combo.get_model()):
On Mon, Jun 24, 2013 at 12:12:05PM -0700, Brian C. Lane wrote:
From: "Brian C. Lane" bcl@redhat.com
pyanaconda/ui/gui/spokes/custom.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
And this has been accepted as a FE, so for f19-branch too.
On Mon, 2013-06-24 at 12:56 -0700, Brian C. Lane wrote:
On Mon, Jun 24, 2013 at 12:12:05PM -0700, Brian C. Lane wrote:
From: "Brian C. Lane" bcl@redhat.com
pyanaconda/ui/gui/spokes/custom.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
And this has been accepted as a FE, so for f19-branch too.
Ack for both branches.
anaconda-patches mailing list anaconda-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
On Mon, 2013-06-24 at 12:12 -0700, Brian C. Lane wrote:
From: "Brian C. Lane" bcl@redhat.com
pyanaconda/ui/gui/spokes/custom.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/pyanaconda/ui/gui/spokes/custom.py b/pyanaconda/ui/gui/spokes/custom.py index da2808c..dfda5dc 100644 --- a/pyanaconda/ui/gui/spokes/custom.py +++ b/pyanaconda/ui/gui/spokes/custom.py @@ -541,7 +541,7 @@ class ContainerDialog(GUIObject):
selected_level_string = store[itr][0] # eg: "RAID1 (Redundancy)" level = selected_level_string.split()[0].lower() # -> "raid1"
if level == "none":
if level == "none" or level == _("None").lower(): level = None
Ack to both branches, indeed. But this part of the code is a time bomb, because the store contains translated strings (from the .glade file) which we split, lower and compare. That should be changed/fixed in the F20 scope. Adding it to my TODO list.
anaconda-patches@lists.fedorahosted.org