It's possible to end up in a situation where the root is "None Linux None for
None" which just looks silly. This happens in my testing if you kill an
install after it's made partitions, but before fedora-release gets installed.
---
pyanaconda/storage/__init__.py | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/pyanaconda/storage/__init__.py b/pyanaconda/storage/__init__.py
index 8df216e..f02230f 100644
--- a/pyanaconda/storage/__init__.py
+++ b/pyanaconda/storage/__init__.py
@@ -3043,9 +3043,15 @@ def findExistingInstallations(devicetree):
try:
(arch, product, version) = getReleaseString()
except ValueError:
- name = "Linux on %s" % device.name
+ name = _("Linux on %s") % device.name
else:
- name = "%s Linux %s for %s" % (product, version, arch)
+ # I'd like to make this finer grained, but it'd be very difficult
+ # to translate.
+ if not product or not version or not arch:
+ name = _("Unknown Linux")
+ else:
+ name = _("%(product)s Linux %(version)s for %(arch)s") % \
+ {"product": product, "version": version,
"arch": arch}
(mounts, swaps) = parseFSTab(devicetree, chroot=ROOT_PATH)
device.teardown()
--
1.7.11.2
Show replies by date
---
pyanaconda/ui/gui/TODO | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/pyanaconda/ui/gui/TODO b/pyanaconda/ui/gui/TODO
index 3be4c45..75c9b0b 100644
--- a/pyanaconda/ui/gui/TODO
+++ b/pyanaconda/ui/gui/TODO
@@ -1,15 +1,15 @@
Fedora 18
=========
-- Add simple keyboard layout selection to welcome language screen.
+- Add encryption option to text mode partitioning.
- Add keyboard options dialog.
+- Add simple keyboard layout selection to welcome language screen.
- Can the entry next to "Closest Mirror" be filled in with something to make it
look less weird?
- Disk tug-o-war needs to be written.
-- Do the really slow redraws happen on real hardware, or just virt?
+- Fix redraw issues.
- Fix retranslating once a different language is selected.
- Live inst in particular needs a more useful installation progress bar.
- Make "Add custom repo..." dialog useful.
- Media install selectors take up all horizontal space on source spoke.
-- Need to sort out checking of storage config against package set space needs.
- Wall of anaconda needs to be taken into account.
- Why does the first hub jump left a little bit the first time you use the keyboard to
navigate?
Software selection also does this.
@@ -25,11 +25,16 @@ Fedora 18
Beyond
======
- "Choose Disks" dialog before hub #1.
+- Add device names to tooltips for DiskOverviews, etc.?
- Code quality:
- Docstrings and comments are lacking.
- Split out especially large spokes (storage.py, custom.py) into logically separate
files.
- Device filtering.
+- "Hub" shouldn't be in the page title for any text mode hub.
+- Make the storage apply button look like it belongs with the rest of the per-mountpoint
+ stuff.
+- Progress reporting for metadata downloading could be handy.
- Spokes should have some way to tell if other spokes are ready (see _software_is_ready
in storage.py).
- Tracking and expressing dependencies on threads is tedious:
--
1.7.11.2
Ack
--
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)