Setting size for custom partition was broken. Blivet now needs normal string instead of unicode.
@dwlehman from what I found this change is need at top of your [commit](https://github.com/rhinstaller/blivet/commit/ee1802babf7ae0ec3abfee4d5cf92a5...). Could you please look on it.
From: Jiri Konecny jkonecny@redhat.com
Setting size for custom partition was broken. Blivet now needs normal string instead of unicode.
Related: rhbz#1196721 --- pyanaconda/ui/gui/spokes/lib/custom_storage_helpers.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pyanaconda/ui/gui/spokes/lib/custom_storage_helpers.py b/pyanaconda/ui/gui/spokes/lib/custom_storage_helpers.py index f5c36e9..b97c9dd 100644 --- a/pyanaconda/ui/gui/spokes/lib/custom_storage_helpers.py +++ b/pyanaconda/ui/gui/spokes/lib/custom_storage_helpers.py @@ -74,7 +74,7 @@ system_mountpoints = ["/dev", "/proc", "/run", "/sys"]
def size_from_entry(entry): - size_text = entry.get_text().decode("utf-8").strip() + size_text = entry.get_text().strip() return size_from_input(size_text)
def populate_mountpoint_store(store, used_mountpoints):
I added this to some of my unrelated testing today and it tested out OK by me. I defer to dwlehman.
Added label: ACK.
Did blivet change, or was it the ```get_text()``` function that changed?
My guess would be that removing of the ``six.string_types`` cause it but why in the first place was here *unicode* I don't know, that code is too old for me.
This looks good to me, but I think we should also have a look at why ``unicode`` objects don't work. I think it would be better if Blivet accepted ``unicode`` objects in such places.
Pushed Thank you all for responses
Closed.
anaconda-patches@lists.fedorahosted.org