A related bug shouldn't override bugs without acks, and it should also have acks itself. --- scripts/makebumpver | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/scripts/makebumpver b/scripts/makebumpver index 4ab94c4..941b509 100755 --- a/scripts/makebumpver +++ b/scripts/makebumpver @@ -355,11 +355,11 @@ class MakeBumpVer: fixedIn) or \ not self._isRHELBugAcked(ckbug, commit, summary)): bad = True - elif valid and action == 'Related' and \ - self._isRHELBugAcked(ckbug, commit, summary): - print "*** Bug %s Related commit %s is allowed\n" % (bug, commit) - # Related bugs only need to be valid and have an ack - bad = False + elif valid and action == 'Related': + if self._isRHELBugAcked(ckbug, commit, summary): + print "*** Bug %s Related commit %s is allowed\n" % (bug, commit) + else: + bad = True
if len(rhbz) == 0 and not self.skip_all: print "*** No bugs referenced in commit %s\n" % commit
On Wed, 2014-10-22 at 20:18 -0700, Brian C. Lane wrote:
A related bug shouldn't override bugs without acks, and it should also have acks itself.
scripts/makebumpver | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/scripts/makebumpver b/scripts/makebumpver index 4ab94c4..941b509 100755 --- a/scripts/makebumpver +++ b/scripts/makebumpver @@ -355,11 +355,11 @@ class MakeBumpVer: fixedIn) or \ not self._isRHELBugAcked(ckbug, commit, summary)): bad = True
elif valid and action == 'Related' and \
self._isRHELBugAcked(ckbug, commit, summary):
print "*** Bug %s Related commit %s is allowed\n" % (bug, commit)
# Related bugs only need to be valid and have an ack
bad = False
elif valid and action == 'Related':
if self._isRHELBugAcked(ckbug, commit, summary):
print "*** Bug %s Related commit %s is allowed\n" % (bug, commit)
else:
bad = True
ACK. I may also have a look at the pre-push hook and check if it does the same (I think it ignores Related/Resolves so it should be okay).
anaconda-patches@lists.fedorahosted.org