----- Original Message -----
From: "Anne Mulhern" <amulhern(a)redhat.com>
To: "anaconda patch review" <anaconda-patches(a)lists.fedorahosted.org>
Sent: Tuesday, December 16, 2014 6:19:29 PM
Subject: Re: [PATCH] LVMFactory: raise exception when adding LV to full fixed size VG
(#1170660)
----- Original Message -----
> From: "Vojtech Trefny" <vtrefny(a)redhat.com>
> To: anaconda-patches(a)lists.fedorahosted.org
> Sent: Tuesday, December 16, 2014 11:03:53 AM
> Subject: [PATCH] LVMFactory: raise exception when adding LV to full fixed
> size VG (#1170660)
>
> ---
> blivet/devicefactory.py | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/blivet/devicefactory.py b/blivet/devicefactory.py
> index e720fbd..03b7aaf 100644
> --- a/blivet/devicefactory.py
> +++ b/blivet/devicefactory.py
> @@ -1134,6 +1134,9 @@ class LVMFactory(DeviceFactory):
>
> if self.device:
> self.size += self.device.size
> +
> + if self.size == 0:
Please make sure to size objects to size objects as:
if self.size == Size(0):
That's a good point. But other than this, the patch
looks good to me.
--
Vratislav Podzimek