Surprise! Everything is different!
I'd like to add a test to catch invalid icons used in the python code (and maybe, Xenu help us, in the C code), but that's going to be super hard and I figured I'd go ahead and address the immediate problems.
The test for whether an icon exists in the icon theme depends on the gnome-icon-theme package, so we'll need that in jenkins.
David Shea (3): Load icons by name instead of stock-id. Add a check for whether icons used in glade files are valid Update icon names used within python code.
pyanaconda/ui/gui/helpers.py | 2 +- pyanaconda/ui/gui/main.glade | 24 ++--- pyanaconda/ui/gui/spokes/advstorage/fcoe.glade | 22 +---- pyanaconda/ui/gui/spokes/advstorage/iscsi.glade | 103 +-------------------- pyanaconda/ui/gui/spokes/datetime_spoke.py | 6 +- pyanaconda/ui/gui/spokes/keyboard.glade | 6 +- pyanaconda/ui/gui/spokes/lib/cart.glade | 8 +- .../ui/gui/spokes/lib/custom_storage_helpers.glade | 4 +- pyanaconda/ui/gui/spokes/lib/dasdfmt.glade | 88 +++++++++--------- pyanaconda/ui/gui/spokes/lib/passphrase.glade | 38 ++++---- pyanaconda/ui/gui/spokes/lib/passphrase.py | 6 +- pyanaconda/ui/gui/spokes/lib/refresh.glade | 16 +--- pyanaconda/ui/gui/spokes/welcome.glade | 6 +- tests/glade/icons/check_icons.py | 72 ++++++++++++++ tests/lib/iconcheck.py | 41 ++++++++ 15 files changed, 216 insertions(+), 226 deletions(-) create mode 100755 tests/glade/icons/check_icons.py create mode 100644 tests/lib/iconcheck.py