On Thu, 2012-11-15 at 11:17 -0500, Samantha N. Bueno wrote:
On Thu, Nov 15, 2012 at 10:23:31AM +0100, Vratislav Podzimek wrote:
On Wed, 2012-11-14 at 16:04 -0500, Samantha N. Bueno wrote:
<>
Adding this to the po-pull target should be enough as the other (relevant) targets have it as dependency.
Ah, ok, good catch. I've fixed that now; although it's simple, new patch below, since I still need to receive an ack on this.
=======
transifex-client shouldn't be listed as a BuildReq; only check for it and install as needed if the target requiring it is called by make
Makefile.am | 1 + anaconda.spec.in | 1 - 2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile.am b/Makefile.am index 4f76895..0badc99 100644 --- a/Makefile.am +++ b/Makefile.am @@ -56,6 +56,7 @@ tag: po-pull: rm -f po/en@boldquot.gmo po/en@boldquot.po rm -f po/en@quot.gmo po/en@quot.po
rpm -q transifex-client &>/dev/null || echo "need to run: yum
install transifex-client"; exit 1 tx pull $(TX_PULL_ARGS)
scratch: po-pull diff --git a/anaconda.spec.in b/anaconda.spec.in index 61dd7ef..7b20a2a 100644 --- a/anaconda.spec.in +++ b/anaconda.spec.in @@ -80,7 +80,6 @@ BuildRequires: python-nose BuildRequires: rpm-devel BuildRequires: rpm-python >= %{rpmpythonver} BuildRequires: slang-devel >= %{slangver} -BuildRequires: transifex-client BuildRequires: xmlto BuildRequires: yum >= %{yumver} BuildRequires: zlib-devel
Looks good to me.