----- Original Message -----
From: "David Lehman" <dlehman(a)redhat.com>
To: "anaconda patch review" <anaconda-patches(a)lists.fedorahosted.org>
Sent: Friday, December 6, 2013 12:06:29 PM
Subject: Re: [blivet 04/13] StorageDevice.minSize returns 0 if format's minSize is
0.
On Fri, 2013-12-06 at 11:50 -0500, mulhern wrote:
> Previously, if format's minSize was 0, then it returned self.size instead.
> I think this was an error, and the intention was to fall back on self.size
> only if format.minSize was not set.
Many formats return 0 for minSize, meaning there is no known minimum
size. It should be treated the same as None, since no formatting
metadata can possibly exist without some space to store it in.
David
How about having those formats return None? I don't know if this is good or bad...but
most arith operators, except +, -, etc. are defined on None, so min(None, 1) is None and
so forth.
- mulhern
_______________________________________________
anaconda-patches mailing list
anaconda-patches(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches