----- Original Message -----
From: "David Shea" <dshea(a)redhat.com>
To: anaconda-patches(a)lists.fedorahosted.org
Sent: Thursday, July 3, 2014 4:53:46 PM
Subject: Re: [libblockdev 0/2] Automating libblockdev project a bit (v2)
On 07/01/2014 11:36 AM, mulhern wrote:
> Made all the changes that were asked for, also added a bunch of comments,
> split out the BlockDev targets into individual ones.
>
> In future will explore removing some of the implicit rules entirely if they
> can be handled by make's built in implicit rules and of course, autotools.
> Might consider changing the namin of the plugin stub files so they can be
> recognized by a simpler pattern.
>
> mulhern (2):
> Make Makefile mostly automatic.
> Ignore all test executables.
>
> .gitignore | 5 ++
> Makefile | 192
> +++++++++++++++++++++++++----------------------
> src/lib/blockdev.c | 13 +---
> src/lib/blockdev.h | 1 -
> src/lib/plugin_apis/dm.h | 2 +-
> src/lib/test_blockdev.c | 2 +
> src/plugins/loop.c | 4 -
> src/plugins/lvm.c | 5 --
> src/plugins/swap.c | 5 --
> src/plugins/test_loop.c | 4 +-
> src/plugins/test_lvm.c | 5 +-
> src/plugins/test_swap.c | 4 +-
> src/utils/sizes.c | 4 -
> src/utils/test_sizes.c | 4 +-
> 14 files changed, 127 insertions(+), 123 deletions(-)
>
These both look good to me.
Regarding your autotool comment, is that something that's going to
happen with libblockdev? Because it's less painful to convert to that
sooner rather than later.
Yeah, point taken ;<
_______________________________________________
anaconda-patches mailing list
anaconda-patches(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches