On Fri, 2013-06-21 at 22:36 -0500, Mark Hamzy wrote:
It seems there are a number of issues with blivet/arch.py:
- A variable is called type in some places and _type in others. This is inconsistent and also overrides a builtin Python keyword.
- Some places call find to search for a substring and others call "in."
- Some places use two spaces for indentation instead of the standard four.
However, since we are in shutdown mode for Fedora 19, I propose that arch.py be rewritten for Fedora 20, and we only fix the bug (I am adding extra comments because it is not obvious that this is a substring search.
Agreed. ACK.