On Thu, 2014-07-03 at 11:19 -0400, mulhern wrote:
I realized that I had been mistaken about somethings, and I noticed a few other things that ought to be fixed up.
First two patches are just testing. The next two are just documentation. The next two are just using udev_device_get_md_*() methods according to their spec. The next two are a very minor bug fix and some accompanying stuff. The final three are the bug fix. Canoncalize... is unchanged, the rest are changed a bit.
mulhern (11): Add test for raid level descriptor None. Add a few small tests for mdexamine Document udev_device_get_uuid() method. Add documentation to udev_device_get_md_*() methods. Do not convert the result of udev_device_get_md_devices() to int. Check for md_level of None Change use of METADATA to MD_METADATA. Add a udev_device_get_md_metadata() method to udev and use it. Canonicalize mdadm generated UUIDS (#1070095) Add new method udev_device_get_md_device_uuid() method (#1070095) Attempt to reset the uuid of the mdraid member device (#1070095)
blivet/devicelibs/mdraid.py | 9 ++++ blivet/devicetree.py | 24 ++++++--- blivet/udev.py | 75 ++++++++++++++++++++++++++- tests/devicelibs_test/mdraid_test.py | 98 +++++++++++++++++++++++++++++++++++- tests/devicelibs_test/raid_test.py | 1 + 5 files changed, 198 insertions(+), 9 deletions(-)
Other than those minor comments these look good to me.