----- Original Message -----
From: "David Lehman" <dlehman(a)redhat.com>
To: "anaconda patch review" <anaconda-patches(a)lists.fedorahosted.org>
Sent: Friday, December 6, 2013 12:11:35 PM
Subject: Re: [blivet 10/13] Add a test that probably should fail.
On Fri, 2013-12-06 at 11:50 -0500, mulhern wrote:
> This test succeeds because a BTRFSSubVolume does not inherit its format
> from its parent. This is probably incorrect; a BTRFSVolume, if it finds
> itself at the end of the constructor with a DefaultFormat, constructs
> a BTRFSFormat format instead. Probably a subvolume should do the same.
> Currently, if the format is not passed in the constructor, the subvolume
> just accepts the DefaultFormat object, which can lead to AttributeErrors.
The test should fail as you suggest. BTRFSSubVolumeDevice must always
have a BTRFS instance as its format.
David
Ok. I'll pull the patch from this patch set and try to fix the bug it identifies for
next.
- mulhern