On Wed, Sep 25, 2013 at 02:21:50PM -0400, David Shea wrote:
scripts/anaconda-yum | 50 +++++++++++++++++++++++++------------------------- scripts/makeupdates | 2 +- 2 files changed, 26 insertions(+), 26 deletions(-)
diff --git a/scripts/anaconda-yum b/scripts/anaconda-yum index 98ebcd1..2bd2a76 100755 --- a/scripts/anaconda-yum +++ b/scripts/anaconda-yum @@ -75,31 +75,31 @@ def run_yum_transaction(release, arch, yum_conf, install_root, ts_file, script_l env_remove = ('DISPLAY', 'DBUS_SESSION_BUS_ADDRESS') [os.environ.pop(k) for k in env_remove if k in os.environ]
- try:
# Setup the basics, point to the config file and install_root
yb = yum.YumBase()
yb.use_txmbr_in_callback = True
[snip]
- except Exception as e:
- except YumBaseError as e: print("ERROR: transaction error: %s" % e) finally: print("QUIT:")
This is broad on purpose. We want to tell anaconda what the error is when it fails, not just die with a traceback. The caller is waiting for output from anaconda-yum and handling any errors that show up.
If anything add another except Exception with a more generic error instead of transaction error.