On Fri, 2013-12-13 at 12:58 -0500, Anne Mulhern wrote:
----- Original Message -----
> From: "Chris Lumens" <clumens(a)redhat.com>
> To: anaconda-patches(a)lists.fedorahosted.org
> Sent: Friday, December 13, 2013 12:10:11 PM
> Subject: Re: [PATCH 4/6] Remove a whole bunch of unused stuff from Blivet.
>
> > > - def doEncryptionPassphraseRetrofits(self):
> > > - """ Add the global passphrase to all preexisting
LUKS devices.
> > > -
> > > - This establishes a common passphrase for all encrypted
> > > devices
> > > - in the system so that users only have to enter one
> > > passphrase
> > > - during system boot.
> > > - """
> > > - if not self.encryptionRetrofit:
> > > - return
> > > -
> > > - for device in self.devices:
> > > - if device.format.type == "luks" and \
> > > - device.format._LUKS__passphrase !=
> > > self.encryptionPassphrase:
> > > - log.info("adding new passphrase to preexisting
encrypted
> > > "
> > > - "device %s" % device.path)
> > > - try:
> > > -
> > > device.format.addPassphrase(self.encryptionPassphrase)
> > > - except CryptoError:
> > > - log.error("failed to add new passphrase to
existing
> > > "
> > > - "device %s" % device.path)
> > > -
> >
> > This seems to be still used by doIt @ line 311.
>
> Nothing in blivet sets self.encryptionRetrofit = True, at least.
Seems like along with the original patch it would make sense to remove the
encryptionRetrofit field entirely.
The only thing that uses it is this method that is being removed.
Done in my working tree here.