On 11/04/2014 12:02 PM, Anne Mulhern wrote:
----- Original Message -----
> From: "David Lehman" <dlehman(a)redhat.com>
> To: anaconda-patches(a)lists.fedorahosted.org
> Sent: Tuesday, November 4, 2014 12:49:43 PM
> Subject: Re: [blivet:master 2/4] Update minSize method headers.
>
> On 11/04/2014 10:46 AM, mulhern wrote:
>> minSize values are no longer in megabytes and a value of Size(0) is
>> ambiguous.
>>
>> Signed-off-by: mulhern <amulhern(a)redhat.com>
>> ---
>> blivet/formats/__init__.py | 9 ++++++++-
>> blivet/formats/fs.py | 2 --
>> 2 files changed, 8 insertions(+), 3 deletions(-)
>>
>> diff --git a/blivet/formats/__init__.py b/blivet/formats/__init__.py
>> index 4867f9c..0891dc5 100644
>> --- a/blivet/formats/__init__.py
>> +++ b/blivet/formats/__init__.py
>> @@ -484,7 +484,14 @@ class DeviceFormat(ObjectID):
>>
>> @property
>> def minSize(self):
>> - """ Minimum size for this format type.
"""
>> + """ Minimum size for this format type.
>> +
>> + :rtype: :class:`~.size.Size`
>> +
>> + Note that a value of Size(0) can mean either that the
>> + minimum size is unknown, or that the minimum size is
>> + actually Size(0).
>> + """
>
> I don't think anything actually has a minimum size of 0 bytes. That
> would indicate it being actually gone, no?
>
> David
Yes, it's unclear to me how that would happen for most filesystems.
There was some comments in TmpFS, that seemed to indicate that a minSize() of
0 could be a reality.
I'm happy to drop the note if you think that comment is a red herring or anyway can
be disregarded.
Please do drop it.