On Fri, 2013-12-13 at 10:01 -0500, Samantha N. Bueno wrote:
On Fri, Dec 13, 2013 at 03:37:21PM +0100, Vratislav Podzimek wrote:
> On Fri, 2013-12-13 at 09:12 -0500, Samantha N. Bueno wrote:
> > Some small edits to the username regex removing capitalized characters
> > as a valid match.
> >
> > Second patch displays an error message in text-mode if a user attempts
> > to create an invalid username, instead of just shoving the prompt in
> > their face again.
> Apart from neatpicks these both look good to me.
Thanks! Typo's fixed locally, and here's the modified test case, since
the change is so small:
diff --git a/tests/regex_tests/username_test.py
b/tests/regex_tests/username_test.py
index 0c0d5d2..7195788 100644
--- a/tests/regex_tests/username_test.py
+++ b/tests/regex_tests/username_test.py
@@ -65,7 +65,6 @@ class UsernameRegexTestCase(unittest.TestCase):
"""Test a list of possible username values."""
good_tests = [
'gburdell',
- 'GBurdell',
'gburdell$',
'g_burdell',
'_burdell',
@@ -90,6 +89,7 @@ class UsernameRegexTestCase(unittest.TestCase):
' gburdell',
':gburdell',
'root',
+ 'GBurdell',
'$',
'-'
]
ACK.
--
Vratislav Podzimek
Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic