On Tue, 2015-06-16 at 18:23 +0200, Martin Kolman wrote:
This patch set aims to restore Initial setup compatibility with the
rebased Anaconda.
The first patch is a nice to have I added when I started working on this:
* previously when import of the main GUI class failed only an error message would be
logged
* the traceback from the failed import would be lost
* so log both the error message and the exception
The second patch contains the actual compatibility fixes, mostly related to category
handling
and other changes that happened on the master & f21-branch and were not backported
previously.
Martin Kolman (2):
Log the reason if GUI import fails (#1229747)
Make Initial Setup compatible with rebased Anaconda (#1229747)
initial_setup/__main__.py | 26 ++++------
initial_setup/common.py | 63 ++++++++++++++++++++++++
initial_setup/gui/gui.py | 6 +--
initial_setup/gui/hubs/initial_setup.glade | 27 +++++++----
initial_setup/gui/hubs/initial_setup_hub.py | 75 ++---------------------------
initial_setup/gui/spokes/eula.glade | 2 -
initial_setup/gui/spokes/eula.py | 9 +++-
initial_setup/post_installclass.py | 2 +-
initial_setup/tui/hubs/initial_setup_hub.py | 11 +++--
initial_setup/tui/spokes/eula.py | 3 +-
initial_setup/tui/tui.py | 4 --
11 files changed, 111 insertions(+), 117 deletions(-)
create mode 100644 initial_setup/common.py
Some of the paths and places where
classes are defined are different
from where addons are expected to put their stuff (e.g. categories to
the 'categories' dir), but I believe you tested this works as expected.
Looks good to me other than the totally minor nitpick in PATCH 2/2.
--
Vratislav Podzimek
Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic