Re: [rhinstaller/blivet/pulls/351 2.1-devel] Installer isolation:
Part One
by dashea
> @@ -69,15 +69,23 @@ class DeviceTreeBase(object, metaclass=SynchronizedMeta):
> :class:`~.deviceaction.DeviceAction` instances can only be registered
> for leaf devices, except for resize actions.
> """
> - def __init__(self, conf=None):
> + def __init__(self, ignored_disks=None, exclusive_disks=None):
> """
> - :keyword conf: storage discovery configuration
> - :type conf: :class:`~.StorageDiscoveryConfig`
> + :keyword ignored_disks: ignored disks
> + :type ignored_disks: list
> + :keyword exclusive_disks: exclusive didks
> + :type exclusive_disks: list
> """
> - self.reset(conf)
> + self.reset(ignored_disks, exclusive_disks)
Pass these as keyword args, please.
--
To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/351#discussion_r58108556
8 years, 1 month
[2.0-devel 1/1] Retrieve udev info as needed in handle_format.
(#1322943)
by dashea
From: David Lehman <dlehman(a)redhat.com>
---
blivet/populator/populator.py | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/blivet/populator/populator.py b/blivet/populator/populator.py
index 816c226..adfa376 100644
--- a/blivet/populator/populator.py
+++ b/blivet/populator/populator.py
@@ -330,8 +330,10 @@ def handle_format(self, info, device):
log_method_call(self, name=getattr(device, "name", None))
if not info:
- log.debug("no information for device %s", device.name)
- return
+ info = udev.get_device(device.sysfs_path)
+ if not info:
+ log.debug("no information for device %s", device.name)
+ return
if not device.media_present:
log.debug("no media present for device %s", device.name)
return
--
To view this commit on github, visit https://github.com/rhinstaller/blivet/commit/8b637b3b256b0691ce8c61fb2306...
8 years, 1 month
[2.1-devel 7/7] Update api to reflect changes from isolating
installer-specific code.
by dashea
From: "Samantha N. Bueno" <sbueno+anaconda(a)redhat.com>
Remove a few methods and attrs that were removed from Blivet class, and
add "mountpoints" attr which was added to DeviceTreeBase.
---
doc/api/blivet.rst | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/doc/api/blivet.rst b/doc/api/blivet.rst
index 4c2d7c1..e0c547f 100644
--- a/doc/api/blivet.rst
+++ b/doc/api/blivet.rst
@@ -22,8 +22,6 @@ blivet
* :mod:`blivet.blivet`
* :class:`~blivet.blivet.Blivet`
* :attr:`~blivet.blivet.Blivet.btrfs_volumes`
- * :meth:`~blivet.blivet.Blivet.clear_partitions`
- * :attr:`~blivet.blivet.Blivet.config`
* :meth:`~blivet.blivet.Blivet.copy`
* :meth:`~blivet.blivet.Blivet.create_device`
* :meth:`~blivet.blivet.Blivet.default_fstype`
@@ -67,7 +65,6 @@ blivet
* :attr:`~blivet.blivet.Blivet.swaps`
* :attr:`~blivet.blivet.Blivet.thinlvs`
* :attr:`~blivet.blivet.Blivet.thinpools`
- * :meth:`~blivet.blivet.Blivet.update_ksdata`
* :attr:`~blivet.blivet.Blivet.vgs`
* :mod:`blivet.deviceaction`
@@ -120,6 +117,7 @@ blivet
* :meth:`~blivet.devicetree.DeviceTreeBase.hide`
* :attr:`~blivet.devicetree.DeviceTreeBase.labels`
* :attr:`~blivet.devicetree.DeviceTreeBase.leaves`
+ * :attr:`~blivet.devicetree.DeviceTreeBase.mountpoints`
* :meth:`~blivet.populator.populator.PopulatorMixin.populate`
* :meth:`~blivet.devicetree.DeviceTreeBase.recursive_remove`
* :meth:`~blivet.devicetree.DeviceTreeBase.resolve_device`
--
To view this commit on github, visit https://github.com/rhinstaller/blivet/commit/bb47ea9bd3b4ffed7156128bb8b9...
8 years, 1 month