> @@ -156,7 +156,12 @@ def apply(self):
> else:
> self._user.gid = None
>
> - self._user.groups = [g.strip() for g in self._tGroups.get_text().split(",")]
> + groups_string = self._tGroups.get_text()
> + # ''.split(',') returns [''] instead of [], which is not what we want
> + if groups_string:
> + self._user.groups = [g.strip() for g in groups_string.split(",")]
> + else:
> + self._user.groups = []
Wouldn't adding ``if g`` (or better ``if g.strip()``) to the end of the list comprehension do the same (plus check for empty strings as groups)?
--
To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/568#discussion_r57675609
I don't really understand why we should be doing this. Wouldn't it be better for the thing that does the hibernation (systemd?) to write the device somewhere? And has something changed over the years that we suddenly need to do this?
--
To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/570
From: "Brian C. Lane" <bcl(a)redhat.com>
Resolves: rhbz#1318952
---
docs/livemedia-creator.1 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/livemedia-creator.1 b/docs/livemedia-creator.1
index 060bb97..fee6e5d 100644
--- a/docs/livemedia-creator.1
+++ b/docs/livemedia-creator.1
@@ -101,7 +101,7 @@ Arguments to pass to qemu-img. Pass once for each argument
>>>>>>> d04a99e... livemedia-creator: Add support for making tarfiles
.TP
-\fB\-\-compress\fR
+\fB\-\-compression\fR
Compression binary for make-tar. xz, lzma, gzip, and bzip2 are supported. xz is the default.
.TP
--
To view this commit on github, visit https://github.com/rhinstaller/lorax/commit/69daa095bfc6851af08aa1b3cc9c602…