New: [rhinstaller/blivet/pulls/234 f23-branch] Fix calling non-existing method (#1252902)
by dashea
Fix my bug from commit (#05feef37e2c5ae8fd63abe2198ccd8d55e09b08a) where
I was calling non-existing device.format.umount() method, the unmount()
(missing 'n') method exists there but it's still only calling teardown()
instead of system umount. I'm changing call to util.umount() which
calling the system umount.
Because of this regression the first call of the
_findExistingInstallations method will raise an exception so no existing
installations were found and everything were in the Unknown group.
The exception was logged to storage log as info so I missed it.
Sorry guys for this issue.
*Related: rhbz#1252902*
*Will go to master branch too*
--
To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/234
8 years, 7 months
[initial-setup][master/f23-branch/rhel7-branch][PATCH] Replace systemd_postun_with_restart with systemd_postun (#1244394)
by Martin Kolman
Otherwise package version upgrades might get stuck if one
of the Initial Setup services is running.
While this should never happen (there should be no other
users triggering package updates logged in when Initial Setup
is running) it apparently can sometimes happen.
So prevent the deadlock by replacing systemd_postun_with_restart
with just systemd_postun.
---
initial-setup.spec | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/initial-setup.spec b/initial-setup.spec
index ef74c55..3f988e8 100644
--- a/initial-setup.spec
+++ b/initial-setup.spec
@@ -80,7 +80,7 @@ rm -rf %{buildroot}
%systemd_preun initial-setup-text.service
%postun
-%systemd_postun_with_restart initial-setup-text.service
+%systemd_postun initial-setup-text.service
%post gui
%systemd_post initial-setup-graphical.service
@@ -89,7 +89,7 @@ rm -rf %{buildroot}
%systemd_preun initial-setup-graphical.service
%postun gui
-%systemd_postun_with_restart initial-setup-graphical.service
+%systemd_postun initial-setup-graphical.service
%files -f %{name}.lang
%doc COPYING README.rst
--
2.4.3
8 years, 7 months
[anaconda][rhel7-branch/master/f23-branch][PATCH] Use otps.display_mode during early startup (#1267140)
by Martin Kolman
The anaconda.displayMode variable is not valid during early startup.
Otherwise the installation language setup logic would always think
anaconda runs in text mode, resulting in languages specified in kickstart
that we can't display in TUI (such as Japanese) falling back to English
not only in TUI but also in GUI, even though GUI can display them just
fine.
Resolves: rhbz#1267140
Signed-off-by: Martin Kolman <mkolman(a)redhat.com>
---
anaconda | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/anaconda b/anaconda
index 1bafc59..cb95b9e 100755
--- a/anaconda
+++ b/anaconda
@@ -1138,10 +1138,10 @@ if __name__ == "__main__":
locale_option = ksdata.lang.lang
else:
locale_option = None
- localization.setup_locale_environment(locale_option, anaconda.displayMode != "g")
+ localization.setup_locale_environment(locale_option, opts.display_mode != "g")
# Now that LANG is set, do something with it
- localization.setup_locale(os.environ["LANG"], ksdata.lang, anaconda.displayMode != "g")
+ localization.setup_locale(os.environ["LANG"], ksdata.lang, opts.display_mode != "g")
import blivet
blivet.enable_installer_mode()
--
2.4.3
8 years, 7 months