Re: [rhinstaller/anaconda/pulls/314 master] Add test documentation
by dashea
Yes, including the generated docs is on purpose. I do a separate run to generate them and copy them over to the gh-pages branch so they'll show up on github. I'm all for documenting the test procedures, but I'm not sure how useful it is to actually document the test code with sphinx. It generally isn't very complicated and if it is going to cause problems with needing packages like dogtail and at-spi-bus-launcher it isn't worth it to block generating the rest of the docs.
--
To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/314
8 years, 9 months
[initial-setup][rhel7-branch/master][PATCH] Don't create /etc/sysconfig/initial-setup on s390 (#1181209)
by Martin Kolman
Systemd unit status is now used for run detection on the s390,
so this file is no longer needed.
Related: rhbz#1181209
Signed-off-by: Martin Kolman <mkolman(a)redhat.com>
---
initial-setup.spec | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/initial-setup.spec b/initial-setup.spec
index 6d313ac..9896b09 100644
--- a/initial-setup.spec
+++ b/initial-setup.spec
@@ -71,15 +71,8 @@ make install-po-files
%find_lang %{name}
%post
-if [ $1 -ne 2 -a ! -f /etc/sysconfig/initial-setup ]; then
- platform="$(arch)"
- if [ "$platform" = "s390" -o "$platform" = "s390x" ]; then
- echo "RUN_INITIAL_SETUP=YES" > /etc/sysconfig/initial-setup
- else
- %systemd_post initial-setup-graphical.service
- %systemd_post initial-setup-text.service
- fi
-fi
+%systemd_post initial-setup-graphical.service
+%systemd_post initial-setup-text.service
%preun
%systemd_preun initial-setup-graphical.service
--
2.4.3
8 years, 9 months
Updated: [rhinstaller/anaconda/pulls/269 master] Package install and debug message logging.
by dashea
This is rework of #214, where was major issue with logging translated
messages to anaconda.log file.
In this rework, this issue is fixed as well as code was cleaned from
previous junk made in attempt to add package logging support.
This rework is attempt to improve package logging, where untranslated
string is logged and translated string is returned back to GUI for user.
Personal thanks for JKonecny for giving details for translation and VPodzime for consultation.
Signed-off-by: Karel Valek <kvalek(a)redhat.com>
--
To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/269
8 years, 9 months
Re: [rhinstaller/anaconda/pulls/314 master] Add test documentation
by dashea
> @@ -21,6 +21,12 @@
> # documentation root, use os.path.abspath to make it absolute, like shown here.
> sys.path.insert(0, os.path.abspath('..'))
>
> +# configuration required to import test modules
> +for path in ["../pyanaconda/isys/.libs", "../pyanaconda", "../tests", "../tests/lib", "../dracut", "../widgets"]:
Works even from the top level directory.
--
To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/314#discussion_r37725463
8 years, 9 months