New: [rhinstaller/anaconda/pulls/336 master] Master port gui spoke to libnm
by dashea
Port of network gui spoke to new libnm.
- Moves to using libnm objects (connection, device, ap) instead of uuids and names which allows for less amount of more readable and maintainable code.
- Removes python-dbus workarounds for secrets flags (could have been done using older libnm-glib as well, if there were not a bug, reported, and fixed now by NM in libnm-glib. Still NM recommends to use the new libnm
- Also allows to get rid of dependency of NetworkControlBox on nm.py (one instance of nm.py function call is still to be removed). As a follow-up NetworkControlBox could be quite easily split out to a module with a glade file independent of ancaonda code which makes its development a lot less pain.
- Using only single client now, which fixes problems with update of some properties and objects (client.get_connections()).
- The first two revert patches are replaced by two patches on top of the set as the port allowed for (and required) this - I think more robust - approach.
--
To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/336
8 years, 8 months
[PATCH 1/3] Add the ability to mark kickstart tests with a type.
by Chris Lumens
You add TESTTYPE="..." to your .sh file. This can include just one word
or it can include multiple words if your test falls into multiple
categories. Then just pass -t <type>. If no tests exist with that
type, run_kickstart_test.sh will fail.
---
tests/kickstart_tests/run_kickstart_tests.sh | 29 ++++++++++++++++++++++++++--
1 file changed, 27 insertions(+), 2 deletions(-)
diff --git a/tests/kickstart_tests/run_kickstart_tests.sh b/tests/kickstart_tests/run_kickstart_tests.sh
index 630813c..0b03a2f 100755
--- a/tests/kickstart_tests/run_kickstart_tests.sh
+++ b/tests/kickstart_tests/run_kickstart_tests.sh
@@ -57,7 +57,9 @@ IMAGE="${TEST_BOOT_ISO}"
# 2 - Keep log files and disk images (will take up a lot of space)
KEEPIT=${KEEPIT:-0}
-while getopts ":i:k:" opt; do
+TESTTYPE=""
+
+while getopts ":i:k:t:" opt; do
case $opt in
i)
# If this wasn't set from the environment, set it from the command line
@@ -71,6 +73,12 @@ while getopts ":i:k:" opt; do
KEEPIT=$OPTARG
;;
+ t)
+ # Only run tests that have TESTTYPE=<this value> in them. Tests can have
+ # more than one type. We'll do a pretty stupid test for it.
+ TESTTYPE=$OPTARG
+ ;;
+
*)
echo "Usage: run_kickstart_tests.sh [-i boot.iso] [-k 0|1|2] [tests]"
exit 1
@@ -98,12 +106,29 @@ env_args=$(printenv | while read line; do
# We get the list of tests from one of two places:
# (1) From the command line, all the other arguments.
-# (2) From finding all scripts in kickstart_tests/ that are executable and are
+# (2) By applying any TESTTYPE given on the command line.
+# (3) From finding all scripts in kickstart_tests/ that are executable and are
# not support files.
if [[ $# != 0 ]]; then
tests="$*"
else
tests=$(find kickstart_tests -name '*sh' -a -perm -o+x -a \! -wholename 'kickstart_tests/run_*.sh')
+
+ newtests=""
+ if [[ "$TESTTYPE" != "" ]]; then
+ for f in ${tests}; do
+ if [[ "$(grep "TESTTYPE=" ${f})" =~ "${TESTTYPE}" ]]; then
+ newtests+="${f} "
+ fi
+ done
+
+ tests="${newtests}"
+ fi
+fi
+
+if [[ "${tests}" == "" ]]; then
+ echo "No tests provided; skipping."
+ exit 77
fi
if [[ "$TEST_REMOTES" != "" ]]; then
--
2.4.3
8 years, 8 months
[initial-setup][rhel7-branch][PATCH] Move gui scriptlets to the gui subpackage (#1181209)
by Martin Kolman
The gui related systemd scriptlets should be called when the gui
subpackage is being manipulated, not the main package.
Related: rhbz#1181209
Signed-off-by: Martin Kolman <mkolman(a)redhat.com>
---
initial-setup.spec | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/initial-setup.spec b/initial-setup.spec
index 8c8cd0e..08908e1 100644
--- a/initial-setup.spec
+++ b/initial-setup.spec
@@ -71,17 +71,23 @@ make install-po-files
%find_lang %{name}
%post
-%systemd_post initial-setup-graphical.service
%systemd_post initial-setup-text.service
%preun
-%systemd_preun initial-setup-graphical.service
%systemd_preun initial-setup-text.service
%postun
-%systemd_postun_with_restart initial-setup-graphical.service
%systemd_postun_with_restart initial-setup-text.service
+%post gui
+%systemd_post initial-setup-graphical.service
+
+%preun gui
+%systemd_preun initial-setup-graphical.service
+
+%postun gui
+%systemd_postun_with_restart initial-setup-graphical.service
+
%files -f %{name}.lang
%doc COPYING README
%{python_sitelib}/initial_setup*
--
2.4.3
8 years, 8 months