Updated: [rhinstaller/anaconda/pulls/182 master] Driverdisk refactor
by dashea
Okay, here it is - the big refactor of driver-updates. `README.dd` still needs to be updated, but the code is all here. It also adds a suite of unit tests for `driver-updates` and a kickstart test for the `driverdisk` command.
Other than some minor text changes the overall behavior should be the same, except for one thing: we no longer attempt to unload running modules. (This is, I think, outside the scope of what problems the driver-updates stuff is designed to solve. `modprobe.blacklist` can handle the rare cases where a driver-updates disk needs to replace an existing module.)
Resolves: RHBZ#1084197
Resolves: RHBZ#1164131
--
To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/182
8 years, 11 months
[PATCH] Update the btrfs kickstart tests to use functions.sh.
by Chris Lumens
---
tests/kickstart_tests/btrfs-1.sh | 13 ++-----------
tests/kickstart_tests/btrfs-2.sh | 13 ++-----------
2 files changed, 4 insertions(+), 22 deletions(-)
diff --git a/tests/kickstart_tests/btrfs-1.sh b/tests/kickstart_tests/btrfs-1.sh
index 2c2f70d..dd83fb0 100755
--- a/tests/kickstart_tests/btrfs-1.sh
+++ b/tests/kickstart_tests/btrfs-1.sh
@@ -17,21 +17,12 @@
#
# Red Hat Author(s): Chris Lumens <clumens(a)redhat.com>
-kernel_args() {
- echo vnc
-}
-
-prepare() {
- ks=$1
- tmpdir=$2
-
- echo ${ks}
-}
+. ${KSTESTDIR}/functions.sh
validate() {
img=$1
- # There should be a /root/RESULT file with results in it. Check
+ # There should be a /root/root/RESULT file with results in it. Check
# its contents and decide whether the test finally succeeded or
# not.
result=$(virt-cat -a ${img} -m /dev/sda2 /root/root/RESULT)
diff --git a/tests/kickstart_tests/btrfs-2.sh b/tests/kickstart_tests/btrfs-2.sh
index 2c2f70d..dd83fb0 100755
--- a/tests/kickstart_tests/btrfs-2.sh
+++ b/tests/kickstart_tests/btrfs-2.sh
@@ -17,21 +17,12 @@
#
# Red Hat Author(s): Chris Lumens <clumens(a)redhat.com>
-kernel_args() {
- echo vnc
-}
-
-prepare() {
- ks=$1
- tmpdir=$2
-
- echo ${ks}
-}
+. ${KSTESTDIR}/functions.sh
validate() {
img=$1
- # There should be a /root/RESULT file with results in it. Check
+ # There should be a /root/root/RESULT file with results in it. Check
# its contents and decide whether the test finally succeeded or
# not.
result=$(virt-cat -a ${img} -m /dev/sda2 /root/root/RESULT)
--
2.4.3
8 years, 11 months
Updated: [rhinstaller/anaconda/pulls/182 master] Driverdisk refactor
by dashea
Okay, here it is - the big refactor of driver-updates. `README.dd` still needs to be updated, but the code is all here. It also adds a suite of unit tests for `driver-updates` and a kickstart test for the `driverdisk` command.
Other than some minor text changes the overall behavior should be the same, except for one thing: we no longer attempt to unload running modules. (This is, I think, outside the scope of what problems the driver-updates stuff is designed to solve. `modprobe.blacklist` can handle the rare cases where a driver-updates disk needs to replace an existing module.)
Resolves: RHBZ#1084197
Resolves: RHBZ#1164131
--
To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/182
8 years, 11 months
[anaconda][rhel7-branch] UI handling for unusable storage
by David Lehman
This, along with the two patches for blivet, fixes bugs 1236995 and
1198367 by presenting the user with a dialog that identifies the
problem, provides some suggestions for resolving it, and allows the
user to go resolve the problem and continue or exit the installer.
8 years, 11 months